This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Update CommonResourceHelper and ResourceHelper tests to Pester 4 standards - #132
Merged
Daniel Scott-Raynsford (PlagueHO) merged 1 commit intoJan 20, 2019
Merged
Conversation
Daniel Scott-Raynsford (PlagueHO)
added
the
needs review
Contributor
|
This is really strange. The Reviewable button points to the xPSDesiredStateConfiguraiton equivalent. 🤔 |
Johan Ljunggren (johlju)
approved these changes
Jan 20, 2019
Johan Ljunggren (johlju)
left a comment
Johan Ljunggren (johlju)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Comment in GitHub review since Reviewable button points wrongly.
Codecov Report
@@ Coverage Diff @@
## dev #132 +/- ##
===================================
Coverage 83% 83%
===================================
Files 19 19
Lines 2760 2760
Branches 4 4
===================================
Hits 2305 2305
Misses 451 451
Partials 4 4 |
Contributor
Author
|
Oh wow - that is pretty weird about the reviewable. I wonder if this is a long standing issue? |
Contributor
|
Daniel Scott-Raynsford (@PlagueHO) First time I have seen it. Didn't see the Reviewable status check either, so probably a temporary glitch |
Contributor
Author
|
Will keep an eye on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR:
CommonResourceHelperunit tests to meet Pester 4.0.0standards (issue #129).
ResourceHelperunit tests to meet Pester 4.0.0standards (issue #129).
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
Johan Ljunggren (@johlju) would you mind reviewing when you get a moment. Should be straight forward.
This change is