Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

PSDscResources: Update LICENSE file to match the Microsoft Open Source Team standard. Fixes Issue #120 - #121

Merged
Daniel Scott-Raynsford (PlagueHO) merged 6 commits into
PowerShell:devfrom
timhaintz:dev
Jan 24, 2019
Merged

PSDscResources: Update LICENSE file to match the Microsoft Open Source Team standard. Fixes Issue #120#121
Daniel Scott-Raynsford (PlagueHO) merged 6 commits into
PowerShell:devfrom
timhaintz:dev

Conversation

@timhaintz

@timhaintz Tim Haintz (timhaintz) commented Nov 4, 2018 •
edited by kwirkykat
Loading

Copy link
Copy Markdown
Contributor

Fixes Issue #120

README.md updated.

This change is Reviewable

@codecov-io

Codecov (codecov-io) commented Nov 4, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #121 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #121   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        19     19           
  Lines      2760   2760           
  Branches      4      4           
===================================
  Hits       2305   2305           
  Misses      451    451           
  Partials      4      4

@stale

stale Bot commented Nov 18, 2018

Copy link
Copy Markdown

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@stale stale Bot added the abandoned The pull request has been abandoned. label Nov 18, 2018
PlagueHO
Daniel Scott-Raynsford (PlagueHO) reviewed Jan 11, 2019
View reviewed changes

@PlagueHO Daniel Scott-Raynsford (PlagueHO) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Tim Haintz (@timhaintz))

README.md, line 581 at r1 (raw file):

* Update LICENSE file to match the Microsoft Open Source Team standard.
    * Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)

Can you connect the "Fixes ..." to the previous line entry: E.g.

* Update LICENSE file to match the Microsoft Open Source Team standard - Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)

@stale stale Bot removed the abandoned The pull request has been abandoned. label Jan 11, 2019
PlagueHO
Daniel Scott-Raynsford (PlagueHO) reviewed Jan 11, 2019
View reviewed changes

@PlagueHO Daniel Scott-Raynsford (PlagueHO) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't abandoned 😁

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Tim Haintz (@timhaintz))

@timhaintz

Tim Haintz (timhaintz) commented Jan 12, 2019

Copy link
Copy Markdown
Contributor Author

Thanks Daniel Scott-Raynsford (@PlagueHO) will fix it today.

@PlagueHO

Daniel Scott-Raynsford (PlagueHO) commented Jan 13, 2019

Copy link
Copy Markdown
Contributor

Cheers Tim Haintz (@timhaintz) - not sure when we will be able to get a merge, but hopefully not too long.

timhaintz
Tim Haintz (timhaintz) commented Jan 13, 2019
View reviewed changes

@timhaintz Tim Haintz (timhaintz) left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on Daniel Scott-Raynsford (@PlagueHO))

README.md, line 581 at r1 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Can you connect the "Fixes ..." to the previous line entry: E.g.

* Update LICENSE file to match the Microsoft Open Source Team standard - Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)

Updated as requested Daniel Scott-Raynsford (@PlagueHO) , let me know if you would like me to update anything else. Thanks, Tim.

timhaintz
Tim Haintz (timhaintz) commented Jan 13, 2019
View reviewed changes

@timhaintz Tim Haintz (timhaintz) left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on Daniel Scott-Raynsford (@PlagueHO))

README.md, line 581 at r1 (raw file):

Previously, timhaintz wrote…

Updated as requested Daniel Scott-Raynsford (@PlagueHO) , let me know if you would like me to update anything else. Thanks, Tim.

Done.

PlagueHO
Daniel Scott-Raynsford (PlagueHO) suggested changes Jan 18, 2019
View reviewed changes

@PlagueHO Daniel Scott-Raynsford (PlagueHO) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Tim Haintz (@timhaintz))

README.md, line 581 at r1 (raw file):

Previously, timhaintz wrote…

Done.

Thanks Tim Haintz (@timhaintz) - can you make one minor change to this: Reduce the line length so that it isn't so long.

E.g.

* Update LICENSE file to match the Microsoft Open Source Team
  standard - Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)

PlagueHO
Daniel Scott-Raynsford (PlagueHO) reviewed Jan 18, 2019
View reviewed changes

@PlagueHO Daniel Scott-Raynsford (PlagueHO) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor tweak to the line length and we'll get this one completed 😁

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Tim Haintz (@timhaintz))

@timhaintz

Tim Haintz (timhaintz) commented Jan 20, 2019

Copy link
Copy Markdown
Contributor Author

Ah, gets me every time! Sorry Daniel Scott-Raynsford (@PlagueHO) . Have updated as requested above, the second line is 89 characters long, is that too long? Pushing now. Thanks, Tim.

@timhaintz

Tim Haintz (timhaintz) commented Jan 20, 2019

Copy link
Copy Markdown
Contributor Author

Daniel Scott-Raynsford (@PlagueHO) just noticed appveyor failed. Do you want me to pull from upstream again or is it something you can resolve?

@timhaintz

Tim Haintz (timhaintz) commented Jan 20, 2019

Copy link
Copy Markdown
Contributor Author

Daniel Scott-Raynsford (@PlagueHO) I've merged the upstream changes. Waiting for tests to run. Thanks, Tim.

timhaintz
Tim Haintz (timhaintz) commented Jan 20, 2019
View reviewed changes

@timhaintz Tim Haintz (timhaintz) left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: hopefully this one is correct. 😄

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on Daniel Scott-Raynsford (@PlagueHO))

PlagueHO
Daniel Scott-Raynsford (PlagueHO) approved these changes Jan 24, 2019
View reviewed changes

@PlagueHO Daniel Scott-Raynsford (PlagueHO) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks Tim Haintz (@timhaintz)

Reviewed 1 of 2 files at r1, 1 of 1 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO
Daniel Scott-Raynsford (PlagueHO) merged commit eaab425 into PowerShell:dev Jan 24, 2019
@timhaintz

Tim Haintz (timhaintz) commented Jan 24, 2019

Copy link
Copy Markdown
Contributor Author

Thanks Daniel Scott-Raynsford (@PlagueHO)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@PlagueHO Daniel Scott-Raynsford (PlagueHO) PlagueHO approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timhaintz @codecov-io @PlagueHO