Conversation
- Adds test for repository names with a single slash that is also a trailing slash - Adds test for repository names with two consecutive slashes - Updates check that name is valid by not allowing names with a single trailing slash
Improves check for valid repository names
Adds code for CodeCov to Travis config.
… applies to testing.
- Only directories should return content, for a file an empty array should be returned.
- Adds specific check for directories - Removes guessing by extension as this gives a different result from regular filesystem behaviour
- The original logic did not properly display all directory content for non-recursive cases when a path was provided.
- Visibility is now assumed to be visible by default - Bug in permission comparison is fixed
- Timestamps for files are retrieved from the github api - Timestamps for directories are calculated from retrieved files
- Uses shorter alias for MockObject instead of FQN - Adds trailing comma to entries in data provider - Removes test that is no longer relevant
…I class - Data for metadata is always retrieved recursively. - Marks Api::getCreatedTimestamp() as being used by Api::getRecursiveMetadata()
- Changed mock data to match changed normalisation format from Api class - Changed mock data to match the fact that metadata is always retrieved recursively - Adds Api::getCreatedTimestamp() as being used by Api::getRecursiveMetadata() - Adds mock for Commits Repository
…erface::getTreeMetadata().
…ntents() - Adds keys to provided data for easy idintifiaction in case of failure - Adds JSON file as fixture
Fixes incorrect directory metadata
Adds integration test and preparations for upcoming release.
Current coverage is
|
|
Changes Unknown when pulling 74e1fbc on develop into * on master*. |
|
Changes Unknown when pulling 3b2ccb0 on develop into * on master*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.3.0