Allow for nested subdirectories in DefaultDataset#570
Open
kasparas-k wants to merge 1 commit into
Open
Conversation
f4d8202 to
7dcb75f
Compare
7dcb75f to
b51216a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While retaining the original behavior with regards to data splits stored in
.jsonfiles, I add support for nested subdirectory structures.This works under the assumption that every point cloud MUST contain at least its
coordasset (otherwise it's not a point cloud). That means that every individual point cloud's assets (normals, color, etc.) in a train/val/etc. split's directory can be located by finding the parent directory of everycoordasset.Given the following
trainsplit directory structureWhen the data split is specified as a subdirectory, and not as a json file
Old behavior:
pc1andpc2are included in the training set,pc3insideextrais skippedNew behavior:
pc1,pc2andpc3are included in the training setThis is a very convenient change for constantly changing datasets, since repeatedly updating a json file is bothersome and error-prone. I've used this modification for months now without issues, so I'd like to contribute it to the community.