Skip to content

Fix rot a to b#3227

Open
yaochengchen wants to merge 5 commits intoPlasmaPy:mainfrom
yaochengchen:fix_rot_a_to_b
Open

Fix rot a to b#3227
yaochengchen wants to merge 5 commits intoPlasmaPy:mainfrom
yaochengchen:fix_rot_a_to_b

Conversation

@yaochengchen
Copy link
Contributor

@yaochengchen yaochengchen commented Feb 24, 2026

Replace exact equality check (== -1) with np.isclose in rot_a_to_b to correctly handle anti-parallel vectors under floating-point rounding.

@github-actions github-actions bot added docs PlasmaPy Docs at http://docs.plasmapy.org plasmapy.formulary Related to the plasmapy.formulary subpackage testing python Pull requests that update Python code labels Feb 24, 2026
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Thank you for submitting this pull request (PR)! ✨

Below are checks that are being run for this PR. Click on the name of a check to learn why it didn't pass. ✅ Don't worry if something broke! We break stuff all the time. 😅

PlasmaPy's contributor guide has pages on:

Tip

📚 For a documentation preview, click on docs/readthedocs.org:plasmapy below. For cryptic documentation errors, see the documentation troubleshooting guide.

Tip

🧹 Automatically fix most pre-commit.ci failures by commenting pre-commit.ci autofix below. For other failures, please see the pre-commit troubleshooting guide.

We thank you once again! 🌌

@codecov
Copy link

codecov bot commented Feb 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.36%. Comparing base (ddda67e) to head (463ee4f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3227   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         108      108           
  Lines        9872     9872           
  Branches     1501     1501           
=======================================
  Hits         9414     9414           
  Misses        262      262           
  Partials      196      196

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the bugfix Pull requests that fix a bug. Remember: a bug is a sign of a missing test! label Feb 24, 2026
@yaochengchen yaochengchen force-pushed the fix_rot_a_to_b branch 2 times, most recently from ac0df5d to 463ee4f Compare February 25, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix Pull requests that fix a bug. Remember: a bug is a sign of a missing test! docs PlasmaPy Docs at http://docs.plasmapy.org plasmapy.formulary Related to the plasmapy.formulary subpackage python Pull requests that update Python code testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yaochengchen