Ensure input files are read as UTF-8#45
Open
refack wants to merge 2 commits into
Open
Conversation
Author
|
Left is content of the released tarball |
Owner
|
Sorry for not responding earlier. I meant to check if this is needed elsewhere too, because I think there's more than one place that creates a parser. |
Owner
|
Please also change the occurrences in It would also be great if you could add a test to |
Author
👍
I'm out of the flow, so I'm not sure how to write a test for this... |
Author
|
I added a second commit that also makes opening the files explicitly as UTF-8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44