chore: require dashboard approval for Renovate PRs - #1016
Merged
Conversation
Renovate no longer opens dependency update PRs automatically. Every available update is listed on the Dependency Dashboard issue and only becomes a PR once its checkbox is ticked.
Docker image for testingImage built and pushed to Harbor:
Use in your services:
patchmon-server:
image: cr.dev.patchmon.cloud/pr/patchmon-server:pr-1016Or use the digest for reproducibility: services:
patchmon-server:
image: cr.dev.patchmon.cloud/pr/patchmon-server@sha256:becb65c7661136eec1d37af1490726588fe1bc455a5a660ae70113fdfd44bed7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
dependencyDashboardApproval: truetorenovate.json.Why
Renovate currently opens dependency update PRs on its own, which adds review noise to the queue. With this change it keeps scanning and keeps reporting, but stops raising PRs unprompted.
Effect
main, since Renovate reads its config from the default branch.Note on security updates
config:recommendedenablesvulnerabilityAlerts, and those PRs are gated by this setting too. If we would rather have CVE fixes keep raising automatically while everything else waits for approval, we can follow up with:Left out of this PR deliberately so the behaviour change here is a single, easily reverted knob.