This repository was archived by the owner on Jan 16, 2021. It is now read-only.
Removed Parse.clientKey requirement for initializing ParseTwitterUtils. - #26
Merged
Conversation
the client key is not a mandatory configuration argument anymore according to the Parse open source server migration guide documentation. `clientKey: The client key for your app. (optional)` https://github.com/ParsePlatform/parse-server/wiki/Parse-Server-Guide
Contributor
|
Nice catch, thanks! Will merge as soon as tests pas. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Contributor
Author
|
I signed up at cla in the meantime... |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Contributor
|
👍 Awesome, merging now. Thanks again. |
nlutsenko
added a commit
that referenced
this pull request
Feb 26, 2016
removed [Parse getClientKey]
nlutsenko
changed the title
Parse.clientKey requirement for initializing ParseTwitterUtils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the client key is not a mandatory configuration argument anymore according to the Parse open source server migration guide documentation.
See: https://github.com/ParsePlatform/parse-server/wiki/Parse-Server-Guide