feat: init binding and async by kehuili · Pull Request #1 · OpenFunction/functions-framework-python-gcp

kehuili · 2022-05-11T12:47:13Z

This big initial PR is an important upgrade to current GCP Python Function Framework with following task accomplished:

Add OpenFunction knative runtime
Add OpenFunction async runtime
Add e2e tests for knative runtime
Add e2e tests for async runtime
Add sequence diagram for knative runtime
Add sequence diagram for async runtime
Refine README

Fix failing assert to look for a different error message, likely due to a change in CloudEvents error message. Also add tests so that code coverage is back at 100%. Signed-off-by: Kehui Li <[email protected]>

Signed-off-by: Kehui Li <[email protected]>

CLAassistant · 2022-05-11T12:48:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ Kehui Li
❌ anniefu

Kehui Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

benjaminhuo · 2022-05-12T02:04:34Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.❌ Kehui Li❌ anniefu

Kehui Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

That's a great enhancement! Thanks @kehuili
Would you sign the CLA? You might need to get around the GFW to sign it.

And to utilize this python functions-framework, we might need to update https://github.com/OpenFunction/builder as well.
Let's discuss this in today's meeting.

Ben

kehuili · 2022-05-12T02:59:12Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.❌ Kehui Li❌ anniefu
Kehui Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

That's a great enhancement! Thanks @kehuili Would you sign the CLA? You might need to get around the GFW to sign it.

And to utilize this python functions-framework, we might need to update https://github.com/OpenFunction/builder as well. Let's discuss this in today's meeting.

Ben

Just signed CLA. Also I picked a commit from GCP for a test fix (or one unit test would fail forever), it seems he/she also need to sign. Do I need to revert this commit and just commit this change myself?

benjaminhuo · 2022-05-12T03:02:31Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.❌ Kehui Li❌ anniefu
Kehui Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

That's a great enhancement! Thanks @kehuili Would you sign the CLA? You might need to get around the GFW to sign it.
And to utilize this python functions-framework, we might need to update https://github.com/OpenFunction/builder as well. Let's discuss this in today's meeting.
Ben

Just signed CLA. Also I picked a commit from GCP for a test fix (or one unit test would fail forever), it seems he/she also need to sign. Do I need to revert this commit and just commit this change myself?

No, just you sign the CLA is all right

tpiperatgod · 2022-05-12T13:23:36Z

+        uri = json_dct.get('uri') or ''
+        component_name = json_dct.get('componentName') or ''
+        metadata = json_dct.get('metadata')
+        component_type = json_dct.get('componentType') or ''
+        operation = json_dct.get('operation') or ''


Would it be better to use get("key", "default")?

tpiperatgod · 2022-05-12T13:35:53Z

lgtm

lizzzcai · 2022-05-13T02:24:27Z

is the quick start example in the readme need to be updated as well?

benjaminhuo · 2022-05-13T03:02:08Z

Kehui Li seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kehuili you may need to add your email used to sign this commit as your github primary email and sign the cla again.

https://docs.github.com/cn/account-and-profile/setting-up-and-managing-your-github-user-account/managing-email-preferences/adding-an-email-address-to-your-github-account

benjaminhuo · 2022-05-13T03:50:11Z

+OPEN_FUNC_BINDING = "bindings"
+OPEN_FUNC_TOPIC = "pubsub"
+
+KNATIVE_RUNTIME_TYPE = "Knative"


Is this runtime type used as the runtime field of serving?
If so it should be in lower case knative or async like https://github.com/OpenFunction/samples/blob/main/functions/async/logs-handler-function/logs-handler-function.yaml#L22

It's for runtime in FUNC_CONTEXT, so I thought it should be capitalized w/ first letter like examples here https://github.com/OpenFunction/samples/blob/bb4e664321f0a2e9d509543936abf9a9b776557c/functions-framework/golang/Knative/http/README.md#func_context

kehuili · 2022-05-13T05:07:18Z

is the quick start example in the readme need to be updated as well?

Definitely gonna add some samples later🙆‍♀️

benjaminhuo · 2022-05-13T06:37:40Z

+    context = _function_registry.get_openfunction_context(None)
+
+    # determine if async or knative
+    if context and context.runtime == ASYNC_RUNTIME_TYPE:


Let's make a case insensitive comparison for xx_RUNTIME_TYPE

Signed-off-by: Kehui Li <[email protected]>

kehuili added the enhancement New feature or request label May 11, 2022

kehuili requested review from benjaminhuo and webup May 11, 2022 12:47

kehuili assigned webup and benjaminhuo May 11, 2022

anniefu and others added 2 commits May 11, 2022 20:48

test: fix unit tests (GoogleCloudPlatform#181)

5b7421e

Fix failing assert to look for a different error message, likely due to a change in CloudEvents error message. Also add tests so that code coverage is back at 100%. Signed-off-by: Kehui Li <[email protected]>

feat: init binding and async

05df573

Signed-off-by: Kehui Li <[email protected]>

kehuili force-pushed the feature/init_binding_and_async branch from de96a02 to 05df573 Compare May 11, 2022 12:48

benjaminhuo requested a review from tpiperatgod May 12, 2022 07:31

tpiperatgod reviewed May 12, 2022

View reviewed changes

benjaminhuo reviewed May 13, 2022

View reviewed changes

fix: refine code

830895a

Signed-off-by: Kehui Li <[email protected]>

kehuili force-pushed the feature/init_binding_and_async branch from 9444e51 to 830895a Compare May 13, 2022 08:56

benjaminhuo approved these changes May 13, 2022

View reviewed changes

benjaminhuo merged commit c011260 into OpenFunction:master May 13, 2022

benjaminhuo mentioned this pull request Jan 28, 2023

Unable to create a python function with asynchronous bindings OpenFunction/OpenFunction#409

Open

Conversation

kehuili commented May 11, 2022

Uh oh!

CLAassistant commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjaminhuo commented May 12, 2022

Uh oh!

kehuili commented May 12, 2022

Uh oh!

benjaminhuo commented May 12, 2022

Uh oh!

tpiperatgod May 12, 2022

Choose a reason for hiding this comment

Uh oh!

kehuili May 13, 2022

Choose a reason for hiding this comment

Uh oh!

tpiperatgod commented May 12, 2022

Uh oh!

lizzzcai commented May 13, 2022

Uh oh!

benjaminhuo commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjaminhuo May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kehuili May 13, 2022

Choose a reason for hiding this comment

Uh oh!

kehuili commented May 13, 2022

Uh oh!

benjaminhuo May 13, 2022

Choose a reason for hiding this comment

Uh oh!

kehuili May 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CLAassistant commented May 11, 2022 •

edited

Loading

benjaminhuo commented May 13, 2022 •

edited

Loading

benjaminhuo May 13, 2022 •

edited

Loading