Skip to content

Let capabilities supply response interceptors - #3446

Merged
velo merged 1 commit into
OpenFeign:masterfrom
hutiefang76:codex/openfeign-2935-response-capability
Jul 28, 2026
Merged

velo merged 1 commit into
OpenFeign:masterfrom
hutiefang76:codex/openfeign-2935-response-capability

Conversation

@hutiefang76

Copy link
Copy Markdown

Summary

Capability.enrich(ResponseInterceptor) was only called for configured response interceptors. If a capability wanted to supply the response interceptor itself, there was no component for it to enrich, so the interceptor was never installed.

This keeps the existing per-interceptor enrichment path, and adds a default pass-through response interceptor only for the empty-list case. If a capability replaces that default interceptor, the replacement is installed before the response interceptor list is enriched as a whole.

Tests

  • ./mvnw -pl core -Dtoolchain.skip=true -Dtest=feign.BaseBuilderTest#capabilityCanProvideResponseInterceptorWhenNoneConfigured test
  • ./mvnw -pl core -Dtoolchain.skip=true -Dtest=feign.BaseBuilderTest test
  • ./mvnw -pl core -Dtoolchain.skip=true test
  • git diff --check

Fixes #2935

@velo velo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via agent-assisted review: change includes tests, no backwards-compatibility break, no security concerns, CI green.

@velo
velo merged commit a6746f5 into OpenFeign:master Jul 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Response interceptor not getting picked from Capability

2 participants