encode string request body with utf-8 not the platform default - #3442
Merged
Merged
Conversation
Signed-off-by: Alhuda Khan <[email protected]>
Contributor
Author
|
any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: build a body with
Request.Body.create(String)on a JVM whose default charset is not UTF-8 (-Dfile.encoding=ISO-8859-1) and send a non-ASCII payload such as"é"; the bytes on the wire are the ISO-8859-1 encoding, not the UTF-8 the rest of feign and the declaredContent-Typeassume.Cause:
create(String)encodes withdata.getBytes(), the platform-default charset, and leaves the bodyencodingnull so it is flagged binary. Every other body path defaults to UTF-8 (RequestTemplate.body(String)and thecreate(String, Charset)overload), so the result is deployment-dependent and the dropped charset meansasString()/charset()cannot recover the text.Fix: delegate to
create(data, UTF_8)so the bytes are deterministic UTF-8 and the charset is recorded, matching the sibling overload.