Skip to content

Return response body in FeignException from errorReading (#2618) #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
velo merged 3 commits into from
Jun 23, 2026
Merged

Return response body in FeignException from errorReading (#2618) #3415

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8e3ac0
Return response body in FeignException from errorReading (#2618)
seonwooj0810 Jun 15, 2026
feb8c31
test: assert response body in errorReading FeignException (#2618)
seonwooj0810 Jun 20, 2026
11c3876
test: assert response body in errorReading for async client modules (…
seonwooj0810 Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: assert response body in errorReading for async client modules (#… 
…2618)

The okhttp/java11/hc5 async client tests still asserted the pre-#2618
request body in throwsFeignExceptionIncludingBody, turning ci/circleci:
pr-build red. Align them with core to expect the response body, matching
the new errorReading behavior.

Signed-off-by: seonwoo_jung <[email protected]>
  • Loading branch information
@seonwooj0810
seonwooj0810 committed Jun 21, 2026
commit 11c387648f964b7c78075804bda1ec8e0a5efe21
3 changes: 2 additions & 1 deletion hc5/src/test/java/feign/hc5/AsyncApacheHttp5ClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,8 @@ void throwsFeignExceptionIncludingBody() throws Throwable {
} catch (final FeignException e) {
assertThat(e.getMessage())
.isEqualTo("timeout reading POST http://localhost:" + server.getPort() + "/");
assertThat(e.contentUTF8()).isEqualTo("Request body");
// After #2618 the FeignException carries the response body, not the request body.
assertThat(e.contentUTF8()).isEqualTo("success!");
return;
}
fail("");
Expand Down
3 changes: 2 additions & 1 deletion java11/src/test/java/feign/http2client/test/Http2ClientAsyncTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,8 @@ void throwsFeignExceptionIncludingBody() throws Throwable {
} catch (final FeignException e) {
assertThat(e.getMessage())
.isEqualTo("timeout reading POST http://localhost:" + server.getPort() + "/");
assertThat(e.contentUTF8()).isEqualTo("Request body");
// After #2618 the FeignException carries the response body, not the request body.
assertThat(e.contentUTF8()).isEqualTo("success!");
return;
}
fail("");
Expand Down
3 changes: 2 additions & 1 deletion okhttp/src/test/java/feign/okhttp/OkHttpClientAsyncTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,8 @@ void throwsFeignExceptionIncludingBody() throws Throwable {
} catch (final FeignException e) {
assertThat(e.getMessage())
.isEqualTo("timeout reading POST http://localhost:" + server.getPort() + "/");
assertThat(e.contentUTF8()).isEqualTo("Request body");
// After #2618 the FeignException carries the response body, not the request body.
assertThat(e.contentUTF8()).isEqualTo("success!");
return;
}
fail("");
Expand Down