Skip to content

Fix flaky vertx http2NoConnectionLeak test by using h2c prior knowledge #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
velo merged 1 commit into from
Jun 3, 2026
Merged

Fix flaky vertx http2NoConnectionLeak test by using h2c prior knowledge #3385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix flaky vertx http2NoConnectionLeak test by using h2c prior knowledge 
Signed-off-by: Marvin Froeder <[email protected]>
  • Loading branch information
@velo
velo committed Jun 3, 2026
commit 6769d9ad4ae3f6a00ebde2932b7b938619e7ee51
9 changes: 8 additions & 1 deletion vertx/feign-vertx/src/test/java/feign/vertx/ConnectionsLeakTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,14 @@ void http2NoConnectionLeak(Vertx vertx, VertxTestContext testContext) {
int poolSize = 1;
int nbRequests = 100;

WebClientOptions options = new WebClientOptions().setProtocolVersion(HttpVersion.HTTP_2);
// Use h2c with prior knowledge instead of the default HTTP/1.1 upgrade: during the upgrade
// handshake the connection is still HTTP/1.1, so the pool applies http1MaxSize (5) rather than
// http2MaxSize (1) and can open several connections under load before the first upgrades to
// HTTP/2 - which made this test flaky on CI.
WebClientOptions options =
new WebClientOptions()
.setProtocolVersion(HttpVersion.HTTP_2)
.setHttp2ClearTextUpgrade(false);
PoolOptions poolOptions = new PoolOptions().setHttp2MaxSize(1);
WebClient webClient = WebClient.create(vertx, options, poolOptions);

Expand Down
9 changes: 8 additions & 1 deletion vertx/feign-vertx4-test/src/test/java/feign/vertx/ConnectionsLeakTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,15 @@ void http2NoConnectionLeak(Vertx vertx, VertxTestContext testContext) {
int poolSize = 1;
int nbRequests = 100;

// Use h2c with prior knowledge instead of the default HTTP/1.1 upgrade: during the upgrade
// handshake the connection is still HTTP/1.1, so the pool applies the HTTP/1.1 max pool size
// rather than the HTTP/2 one and can open several connections under load before the first
// upgrades to HTTP/2 - which made this test flaky on CI.
WebClientOptions options =
new WebClientOptions().setProtocolVersion(HttpVersion.HTTP_2).setHttp2MaxPoolSize(1);
new WebClientOptions()
.setProtocolVersion(HttpVersion.HTTP_2)
.setHttp2MaxPoolSize(1)
.setHttp2ClearTextUpgrade(false);
WebClient webClient = WebClient.create(vertx, options);

HelloServiceAPI client =
Expand Down