Skip to content

Add MethodInterceptor extension point with feign-validation and feign-http-cache modules #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
velo merged 5 commits into from
May 7, 2026
Merged

Add MethodInterceptor extension point with feign-validation and feign-http-cache modules #3346

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa9848e
Add MethodInterceptor extension point with feign-validation and feign…
velo May 7, 2026
57687b0
Move MethodInterceptor classes into feign.interceptor package
velo May 7, 2026
0bad174
Convert CachedEntry to a Java record
velo May 7, 2026
2c6c0d4
Add MethodInterceptor branch to README feature overview mindmap
velo May 7, 2026
eb0daad
Add Invocation.body() and apply review cleanups (chain reduce, no-sto…
velo May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Convert CachedEntry to a Java record 
Signed-off-by: Marvin Froeder <[email protected]>
  • Loading branch information
@velo
velo committed May 7, 2026
commit 0bad174a3f4837328304e3f7253141d0a387c956
6 changes: 6 additions & 0 deletions http-cache/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@
<name>Feign HTTP Cache</name>
<description>Feign HTTP Cache (ETag / Last-Modified)</description>

<properties>
<main.java.version>17</main.java.version>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
</properties>

<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
Expand Down
31 changes: 1 addition & 30 deletions http-cache/src/main/java/feign/cache/CachedEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,33 +20,4 @@

/** Immutable cache record produced from a successful response with revalidation headers. */
@Experimental
public final class CachedEntry {

private final Object value;
private final String etag;
private final String lastModified;
private final Instant storedAt;

public CachedEntry(Object value, String etag, String lastModified, Instant storedAt) {
this.value = value;
this.etag = etag;
this.lastModified = lastModified;
this.storedAt = storedAt;
}

public Object value() {
return value;
}

public String etag() {
return etag;
}

public String lastModified() {
return lastModified;
}

public Instant storedAt() {
return storedAt;
}
}
public record CachedEntry(Object value, String etag, String lastModified, Instant storedAt) {}