fix(settings/overview): 清理 Windows 上不适用的 UI 选项/标签/布局 - #799
Merged
Conversation
Windows 没有 Command 键,leftCommand/rightCommand 会被映射到 Win 键,而单按 Win 弹出开始菜单,实际无法作为录音热键。从 Windows 的 available_triggers 里删掉这两个 预设,前端「常用单键」chip 便不再展示;不影响 HotkeyTrigger 枚举本身与已有绑定。 Fixes Open-Less#784 Co-Authored-By: Claude Opus 4.8 <[email protected]>
- Open-Less#783 补齐 hotkey.triggers 缺失的 leftShift/rightShift/leftCommand i18n(5 语言); 之前缺 key 导致预设 chip 渲染成裸串 "hotkey.triggers.xxx"(用户看到的 "host…") - Open-Less#786 移除「粘贴快捷键」里的 Shift+Insert (xterm/urxvt) 选项——这组设置只在 Windows 出现,而该选项是 X11 终端专用,放 Windows 上纯误导 - Open-Less#785 删除「自动更新」下方错位的 hotkey statusHint(本属快捷键区,误挂到启动组) - Open-Less#780 「胶囊确认插入 ✓」速查行改为仅 macOS——Windows/Linux 胶囊无此按钮 - Open-Less#781 「年度活动」卡片补 marginBottom,与上方卡片 18px 节奏一致 - Open-Less#782 「近 7 天」卡片加 overflow:hidden,窗口过小时柱状图不再溢出卡片圆角外 Fixes Open-Less#783, Open-Less#786, Open-Less#785, Open-Less#780, Open-Less#781, Open-Less#782 Co-Authored-By: Claude Opus 4.8 <[email protected]>
Contributor
PR Reviewer Guide 🔍(Review updated until commit 2e7455f)Here are some key observations to aid the review process:
|
Collaborator
|
开始审查 |
Contributor
|
Persistent review updated to latest commit 2e7455f |
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
清理 Windows 端一批「显示了但不适用」的 UI 选项 / 标签 / 布局(均为 @aeoform 报告)。
available_triggers删掉leftCommand/rightCommand;不影响HotkeyTrigger枚举与已有绑定。hotkey.triggers缺失的leftShift/rightShift/leftCommandi18n(zh-CN / en / ja / ko / zh-TW)。之前缺 key,i18next 直接回落成裸串hotkey.triggers.xxx(报告里看到的 "host…" 其实是 "hotkey…" 截断)。Shift+Insert (xterm/urxvt)选项——这组设置只在 Windows 出现(macOS 走 macEventTap 不显示、Linux 被showDesktopInsert排除),而该选项是 X11 老式终端专用,放 Windows 上纯误导。statusHint(它本属快捷键区,被误挂到启动组底部;onboarding 里仍有它)。os !== 'linux'把它也展示给了 Windows。marginBottom,与上方 provider / metrics 两行的 18px 节奏一致,不再直接贴住下一行。overflow:hidden,窗口过小时这一行flex:1会被压到比内容还矮,固定高的柱状图原本会溢出卡片圆角外;裁进卡片内,与右侧「最近识别」卡片一致。验证
tsc --noEmit✅ /cargo check✅(对 beta)Fixes #784, #783, #786, #785, #780, #781, #782
🤖 Generated with Claude Code
PR Type
Bug fix
Description
移除 Windows 不适用的热键预设与 UI 选项
补齐 i18n 缺失的 Shift/Command 键标签
修复窗口缩小时的视图溢出与间距问题
自动迁移旧配置 (Shift+Insert → Ctrl+V)
Diagram Walkthrough
File Walkthrough
10 files
移除 Windows 的 Command 单键预设补齐英文 i18n 缺失的键标签补齐日文 i18n 缺失的键标签补齐韩文 i18n 缺失的键标签补齐简体中文 i18n 缺失的键标签补齐繁体中文 i18n 缺失的键标签更新 mock 数据匹配 Windows 预设修复卡片溢出与间距问题移除 Shift+Insert 选项并迁移旧配置限制胶囊确认提示仅 macOS 显示1 files
缓存最新偏好配置用于迁移