Skip to content

fix(settings/overview): 清理 Windows 上不适用的 UI 选项/标签/布局 - #799

Merged
H-Chris233 merged 3 commits into
Open-Less:betafrom
bigsongeth:fix/windows-ui-cleanup
Jul 14, 2026
Merged

fix(settings/overview): 清理 Windows 上不适用的 UI 选项/标签/布局#799
H-Chris233 merged 3 commits into
Open-Less:betafrom
bigsongeth:fix/windows-ui-cleanup

Conversation

@bigsongeth

@bigsongeth bigsongeth commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

User description

清理 Windows 端一批「显示了但不适用」的 UI 选项 / 标签 / 布局(均为 @aeoform 报告)。

验证

Fixes #784, #783, #786, #785, #780, #781, #782

🤖 Generated with Claude Code


PR Type

Bug fix


Description

  • 移除 Windows 不适用的热键预设与 UI 选项

  • 补齐 i18n 缺失的 Shift/Command 键标签

  • 修复窗口缩小时的视图溢出与间距问题

  • 自动迁移旧配置 (Shift+Insert → Ctrl+V)


Diagram Walkthrough

flowchart LR
  trigger["Fix Windows unusable UI"] 
  trigger -- "Remove Command keys" --> types_rs["types.rs"]
  trigger -- "Add missing i18n keys" --> i18n["i18n files (5 langs)"]
  trigger -- "Remove Shift+Insert option" --> recording["RecordingInputSection.tsx"]
  trigger -- "Restrict statusHint to macOS" --> shortcuts["ShortcutsSection.tsx"]
  trigger -- "Fix overflow & margin bugs" --> overview["Overview.tsx"]
  trigger -- "Migrate old config" --> recording
Loading

File Walkthrough

Relevant files
Bug fix
10 files
types.rs
移除 Windows 的 Command 单键预设                                                               
+3/-2     
en.ts
补齐英文 i18n 缺失的键标签                                                                                 
+3/-0     
ja.ts
补齐日文 i18n 缺失的键标签                                                                                 
+3/-0     
ko.ts
补齐韩文 i18n 缺失的键标签                                                                                 
+3/-0     
zh-CN.ts
补齐简体中文 i18n 缺失的键标签                                                                             
+3/-0     
zh-TW.ts
补齐繁体中文 i18n 缺失的键标签                                                                             
+3/-0     
mock-data.ts
更新 mock 数据匹配 Windows 预设                                                                   
+3/-1     
Overview.tsx
修复卡片溢出与间距问题                                                                                           
+6/-2     
RecordingInputSection.tsx
移除 Shift+Insert 选项并迁移旧配置                                                                 
+19/-7   
ShortcutsSection.tsx
限制胶囊确认提示仅 macOS 显示                                                                             
+3/-1     
Enhancement
1 files
HotkeySettingsContext.tsx
缓存最新偏好配置用于迁移                                                                                         
+1/-0     

bigsongeth and others added 2 commits July 13, 2026 16:39
Windows 没有 Command 键,leftCommand/rightCommand 会被映射到 Win 键,而单按 Win
弹出开始菜单,实际无法作为录音热键。从 Windows 的 available_triggers 里删掉这两个
预设,前端「常用单键」chip 便不再展示;不影响 HotkeyTrigger 枚举本身与已有绑定。

Fixes Open-Less#784

Co-Authored-By: Claude Opus 4.8 <[email protected]>
- Open-Less#783 补齐 hotkey.triggers 缺失的 leftShift/rightShift/leftCommand i18n(5 语言);
  之前缺 key 导致预设 chip 渲染成裸串 "hotkey.triggers.xxx"(用户看到的 "host…")
- Open-Less#786 移除「粘贴快捷键」里的 Shift+Insert (xterm/urxvt) 选项——这组设置只在 Windows
  出现,而该选项是 X11 终端专用,放 Windows 上纯误导
- Open-Less#785 删除「自动更新」下方错位的 hotkey statusHint(本属快捷键区,误挂到启动组)
- Open-Less#780 「胶囊确认插入 ✓」速查行改为仅 macOS——Windows/Linux 胶囊无此按钮
- Open-Less#781 「年度活动」卡片补 marginBottom,与上方卡片 18px 节奏一致
- Open-Less#782 「近 7 天」卡片加 overflow:hidden,窗口过小时柱状图不再溢出卡片圆角外

Fixes Open-Less#783, Open-Less#786, Open-Less#785, Open-Less#780, Open-Less#781, Open-Less#782

Co-Authored-By: Claude Opus 4.8 <[email protected]>
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 2e7455f)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

780 - Partially compliant

Compliant requirements:

  • The confirm shortcut hint is now conditionally displayed only on macOS (changed from os !== 'linux' to os === 'mac'), so it no longer appears on Windows.

Non-compliant requirements:

(none)

Requires further human verification:

(none)

782 - Partially compliant

Compliant requirements:

  • Added overflow: hidden to the Card wrapping the week chart, preventing content overflow outside the card's rounded corners.

Non-compliant requirements:

(none)

Requires further human verification:

(none)

784 - Partially compliant

Compliant requirements:

  • Removed leftCommand and rightCommand from available_triggers in the Windows-specific block of types.rs.
  • Updated mock data accordingly.

Non-compliant requirements:

(none)

Requires further human verification:

(none)

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@H-Chris233

Copy link
Copy Markdown
Collaborator

开始审查

@github-actions

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 2e7455f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[area] Windows没有command快捷键

2 participants