Conversation
pieh
added this pull request to stack #39686
September 11, 2026 10:29
gatsbot
Bot
added
the
status: triage needed
pieh
force-pushed
the
release-please/2-setup
branch
from
September 11, 2026 11:53
b644fad to
d5b94d7
Compare
pieh
changed the title
pieh
commented
Sep 11, 2026
| { | ||
| "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", | ||
| "bootstrap-sha": "aea34d80b48583f36894eae89de0b90581201c6b", | ||
| "last-release-sha": "aea34d80b48583f36894eae89de0b90581201c6b", |
Contributor
Author
There was a problem hiding this comment.
last-release-sha only needed for very first publish - will need to remove this later
pieh
removed
the
status: triage needed
pieh
commented
Sep 11, 2026
Comment on lines
+109
to
+121
| // No package has its own LICENSE - lerna copied the root one into each package | ||
| // directory for the duration of the pack, so every published tarball has one. | ||
| // Keep doing that: npm includes LICENSE regardless of `files`/.npmignore. | ||
| function withRootLicenses(packages) { | ||
| const source = path.join(rootPath, `LICENSE`) | ||
| const copied = packages | ||
| .map(pkg => path.join(pkg.location, `LICENSE`)) | ||
| .filter(target => !fs.existsSync(target)) | ||
|
|
||
| copied.forEach(target => fs.copyFileSync(source, target)) | ||
|
|
||
| return () => copied.forEach(target => fs.rmSync(target, { force: true })) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this preserve handling that lerna publish was doing automatically. Without it move to npm publish would stop including LICENSE in released packages
pieh
commented
Sep 11, 2026
Comment on lines
+63
to
+92
| async function isPublished({ name, version }, attempt = 1) { | ||
| try { | ||
| const { stdout } = await run(`npm`, [ | ||
| `view`, | ||
| `${name}@${version}`, | ||
| `version`, | ||
| ]) | ||
| // Some npm versions answer an unknown version with an empty success | ||
| // rather than an error | ||
| return stdout.trim() !== `` | ||
| } catch (error) { | ||
| const output = `${error.stdout || ``}${error.stderr || ``}` | ||
| const isMissing = | ||
| output.includes(`E404`) || | ||
| output.includes(`No match found`) || | ||
| output.includes(`is not in this registry`) | ||
|
|
||
| if (isMissing) { | ||
| return false | ||
| } | ||
| if (attempt < REGISTRY_ATTEMPTS) { | ||
| console.log(` ${name}@${version}: lookup failed, retrying (${attempt})`) | ||
| await delay(attempt * 1000) | ||
| return isPublished({ name, version }, attempt + 1) | ||
| } | ||
| throw new Error( | ||
| `Could not determine whether ${name}@${version} is published:\n${output}` | ||
| ) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is replacement for lerna's --from-package (skip trying to publish version that already is on npm)
pieh
commented
Sep 11, 2026
Comment on lines
+35
to
+37
|
|
||
| # changelogs are generated by release-please, which formats them its own way | ||
| packages/*/CHANGELOG.md |
Contributor
Author
There was a problem hiding this comment.
CHANGELOG.md additions produced by release-please fail prettier, but as they are generated and not hand-written, it seems best to avoid linting them (instead of trying to format them after release-please which gets complicated and the more straight forward setup is the better)
pieh
marked this pull request as ready for review
September 11, 2026 14:04
pieh
force-pushed
the
release-please/2-setup
branch
from
September 14, 2026 19:40
d5b94d7 to
79d0ad6
Compare
pieh
removed this pull request from stack #39686
September 14, 2026 19:42
pieh
changed the base branch from
release-please/1-reset-package-versions
to
release-please/1b-no-changelog-in-tarballs
September 14, 2026 19:43
pieh
added this pull request to stack #39692
September 14, 2026 19:43
pieh
force-pushed
the
release-please/2-setup
branch
from
September 14, 2026 19:45
79d0ad6 to
a781c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relies on #39684
Documentation
Tests
Related Issues