Fix SQLite Result ValueDateTime data-type regression bug and related test populated.sql db errors#169
Merged
emiliom merged 2 commits intoODM2:developmentfrom Apr 20, 2019
Merged
Conversation
Fixed a set of 40 TimeSeriesResultValues insert statements in the populated.sql test SQLite database creation file, where the datetimes where only specified as dates, not datetimes; and around 2000 statements that used mm/dd/yyyy format rather than yyyy/mm/dd. They were leading to the use of a non-datetime field type. Also changed odm2api module path calls in test_odm2/test_readservice.py to remove deprecated use of ODM2 module hierarchy. Fixed other test TimeSeriesResultValues datetime entries
Member
Author
|
The main Travis CI TEST_TARGET ("default", Python 2.7) is passing. "coding_standards" test target is failing due to long-standing code patterns, but that doesn't get in the way of a successful build. Appveyor CI hasn't been working for quite a while, so I'm ignoring its failures. Merging PR. |
This was referenced Apr 20, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158.
Tested on the timeseries notebook at https://github.com/ODM2/ODM2PythonAPI/blob/master/Examples/TimeSeries_RetrieveVisualize.ipynb
While testing and debugging, discovered that #158 was related to the presence of messy (bad/invalid) datetime strings in the tests/test_odm2/data/populated.sql test SQLite database ddl. Fixing that file in this PR.