Skip to content

Comments

Missed builtin, should be last one#138

Merged
emiliom merged 1 commit intoODM2:developmentfrom
lsetiawan:fix_getcv
Jan 5, 2018
Merged

Missed builtin, should be last one#138
emiliom merged 1 commit intoODM2:developmentfrom
lsetiawan:fix_getcv

Conversation

@lsetiawan
Copy link
Member

Overview

Missed the builtins type in getCVs function. This should be the last ones, according to travis-CI.

@lsetiawan lsetiawan requested a review from emiliom January 5, 2018 23:05
@lsetiawan
Copy link
Member Author

This also addresses #115.

@emiliom
Copy link
Member

emiliom commented Jan 5, 2018

Missed the builtins type in getCVs function. This should be the last ones, according to travis-CI.

Do you mean the last type builtin, or the last builtin altogether (ie, no more misuse of builtins!)? If it's the latter, this PR will close #115

@lsetiawan
Copy link
Member Author

Give TravisCI another few minutes until flake8 test is done, and we will see if it's the last misused builtin. Thanks.

@emiliom emiliom merged commit b572e29 into ODM2:development Jan 5, 2018
@emiliom emiliom mentioned this pull request Jan 5, 2018
@lsetiawan lsetiawan deleted the fix_getcv branch January 5, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants