Error in DataLoggerFiles and DataLoggerFileColumns #132#133
Error in DataLoggerFiles and DataLoggerFileColumns #132#133miguelcleon wants to merge 6 commits intoODM2:masterfrom
Conversation
|
why did this fail @lsetiawan @ocefpaf ? |
|
also found two more problems with dataloggerfiles model There is no column |
|
I can confirm instances of these models can now be retrieved without error. |
|
Sorry for replying to this so late. Was out sick yesterday. It seems like travis error is from Python 3.2 and 3.3 not being able to build the conda environment. Nothing to do with the changes. But, changes should go into the development branch rather than master. Please be advised. Thanks. |
lsetiawan
left a comment
lsetiawan
left a comment
There was a problem hiding this comment.
Looks good to me. Only thing, changes should be merged into development branch not master.
lsetiawan
force-pushed
the
master
branch
2 times, most recently
from
4acdf62 to
2f82702
Compare
|
|
||
| sudo: required | ||
|
|
||
| # if the https://travis-ci.org/ODM2/ODM2PythonAPI/requests ever says: missing config |
There was a problem hiding this comment.
@miguelcleon Any reason why these were added? It seems like your changes may have broken Travis CI.
There was a problem hiding this comment.
Any changes to Travis should go through a PR so it doesn't just break without anyone knowing why. Thanks. I am going to roll back your changes to fix Travis.
There was a problem hiding this comment.
Your changes are now in PR, please remove any change in .travis.yml
There was a problem hiding this comment.
Yes this looks like a change I didn't mean to include.
|
Moved to #134. Closing. |
2 participants
@lsetiawan I went ahead and made the fix for issue #132
see that the first one, this is caused by Dataloggerfiles model, mapping to the wrong column within the database: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L458.
For the second one, measurementequation is indeed misspelled: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L514.