Fix Processing Levels code and docstring#129
Merged
lsetiawan merged 1 commit intoODM2:developmentfrom Nov 22, 2017
Merged
Conversation
Member
|
Looks good to me. Please merge once the remaining CI/check is completed. FYI, it seems surprising -- and disappointing -- that the interpreter doesn't catch the use of an object property that doesn't exist in the class model, and the error is only exposed when actually using the query function. Hmm. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses #128. It also update the docstring to follow our convention.