Merged
Conversation
added 11 commits
November 9, 2017 10:46
… some BigInteger values in models.py were the incorrect type
sreeder
requested review from
Elijahwalkerwest,
emiliom,
horsburgh,
lsetiawan and
ocefpaf
lsetiawan
reviewed
Nov 13, 2017
| print('Error running Query {}'.format(e)) | ||
| return None | ||
|
|
||
| def getDataSetsValues(self, ids=None, codes=None, uuids=None, dstype=None): |
Member
There was a problem hiding this comment.
Where is the docstring for this function?
Contributor
Author
There was a problem hiding this comment.
I knew I forgot something on there! I will add that right now
lsetiawan
approved these changes
Nov 13, 2017
Member
lsetiawan
left a comment
lsetiawan
left a comment
There was a problem hiding this comment.
Just one question, otherwise, LGTM. 😄
Member
|
@sreeder Are you merging this or should I? I assume you have tested this? Thanks. |
Contributor
Author
|
@lsetiawan yes I have tested it. I even created and uploaded tests for each of the functions. Oh, and I can merge it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the functions getdatasetvalues and getdatasetresults. it also adds test and fixes a minor bug in the getsamplingfeaturedatasets function. It also adds all of the requested parameters to the getdatasets function.