fix: Improve Unity version checks and license activation#23
Merged
Conversation
Refactored getUnityExecutablePath for conciseness and updated isUnityVersionInstalled to use async fs.pathExists. Added credential validation to license activation, returning an error if required credentials are missing.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Unity version checks and adds validation to license activation. The changes improve code conciseness and modernize file existence checks by adopting async patterns.
- Simplified
getUnityExecutablePathby removing an intermediate variable - Updated
isUnityVersionInstalledto use asyncfs.pathExistsinstead of synchronousfs.existsSync - Added credential validation to
activateLicenseto catch missing credentials early
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored getUnityExecutablePath for conciseness and updated isUnityVersionInstalled to use async fs.pathExists. Added credential validation to license activation, returning an error if required credentials are missing.