Our JS Capstone Project Using Google books API #37
Conversation
Add header to the html file
Add footer and Css-loader
Create Home page to contain retrieving data from the api
Fix Linters add Create comment API
Create a module for total comments and get comments
Add coment details (username, date) & check linters
Add test to create comments
BenMukebo
left a comment
BenMukebo
left a comment
There was a problem hiding this comment.
Hi @NelsonAraujo93, @MMGGYY66,
You did a great job so far 👏🏼 👏🏼
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 🎉
- Git flow is followed. ✔️
- You have followed JavaScript best practices. ✔️
- Professional README file. ✔️
- PR has a good title and summary. ✔️
- Your app has been well deployed using to Heroku, Netlify or GitHub Pages. ✔️
- Your Design looks awesome, keep rocking 🚀
STATUS: CHANGES REQUESTED ♻️
Please Check the comments under the review and make all required changes
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers 🥂 and Happy coding!!! 👯💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @BenMukebo when you comment so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/index.js
Outdated
| window.onload = async () => { | ||
| likesData = await getAllLikes(); | ||
| loadLogo(); | ||
| retrieveBooks(); | ||
| }; |
There was a problem hiding this comment.
- [OPTIONAL] What happens if you prevent the page from loading every time the user makes a like 🤔 This can prevent the user from losing sight of the article or book they just loved. Currently, when I like the book, it loads the same as the page and when I render new data on the UI, it was not easy to find the book I just liked
when give likes to a book
franclobo
left a comment
franclobo
left a comment
There was a problem hiding this comment.
Hi team,
#STATUS: APPROVED 😃
In my opinion, your project is ready for the presentation! There is nothing else to say other than... it's time to merge it 
Highlight
- Correct Git flow ✔️
- Professional README file ✔️
- Good topic ✔️
- Nice logo ✔️
Good luck! 🎉
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Merge pull request #37 from NelsonAraujo93/dev
In this project we were 2 coding partner and we divided our work as follow:
We agreed upon choose Google Books API in this link: https://developers.google.com/books/docs/v1/getting_started
And for sending information to get and post comments and likes we used : https://www.notion.so/Involvement-API-869e60b5ad104603aa6db59e08150270
Also we finished all the requirements asked in the projects.
Day 0
Day 1
Day 2
Day 3