Skip to content

36/add sticky notification for android 13 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AchoArnold merged 2 commits into from
Dec 15, 2022
Merged

36/add sticky notification for android 13 #37

AchoArnold merged 2 commits into from
Dec 15, 2022

Conversation

@AchoArnold
Copy link
Member

@AchoArnold AchoArnold commented Dec 15, 2022

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Dec 15, 2022

  • The diff above is a change to the FirebaseMessagingService.kt file, which handles sending SMS messages from HTTP requests
  • It adds an additional check for permissions on Android versions >= 33 (Android 11)
  • If this permission is not granted, it will request that permission before attempting to send any SMS message via HTTP request
  • This prevents users of older devices running newer OSes from being unable to use the app without granting notification access manually in settings

@AchoArnold AchoArnold merged commit a9a138e into main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AchoArnold