Add a size parameter for ConstGenericRingBuffer::new#110
Merged
Conversation
tertsdiepraam
changed the title
ConstGenericRingBuffer::new
tertsdiepraam
force-pushed
the
size-parameter-on-new
branch
from
da74f59 to
fff586c
Compare
Collaborator
|
I kinda like this @NULLx76, what're your thoughts? |
NULLx76
reviewed
Jun 8, 2023
NULLx76
pushed a commit
that referenced
this pull request
Jul 11, 2025
Add a size parameter for `ConstGenericRingBuffer::new`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor ergonomic improvement which allows us to write:
instead of
when the type can be inferred, saving a grand total of 2 characters (3 if you count the space)!
This trick (ab)uses
Fromas a stand-in for an identity trait. This is probably fine, because there is only one possible implementation of thefrommethod, which is the identity function, sinceFromis guaranteed to be reflexive via a blanket impl.