tests/NLog.UnitTests/Config/ConfigApiTests.cs (1)

343-352: Test correctly validates new FinalMinLevel behavior.

The test appropriately mirrors LogRuleMinLevel_enables and validates that setting FinalMinLevel on a fresh rule in the Off state enables the expected levels and updates MinLevel.

Consider adding a complementary test verifying that FinalMinLevel does not update MinLevel when the rule already has levels enabled (i.e., when _logLevelFilter is not Off). This would ensure the conditional logic in the setter is fully exercised.

💡 Optional: Additional test for non-Off state

[Fact]
public void LogRuleFinalMinLevel_DoesNotChangeExistingMinLevel()
{
    var rule = new LoggingRule();
    rule.MinLevel = LogLevel.Debug; // Rule is no longer in Off state
    rule.FinalMinLevel = LogLevel.Warn;
    // MinLevel should remain Debug, not change to Warn
    Assert.Equal(LogLevel.Debug, rule.MinLevel);
    Assert.Equal(new[] { LogLevel.Debug, LogLevel.Info, LogLevel.Warn, LogLevel.Error, LogLevel.Fatal }, rule.Levels);
}

,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/NLog.UnitTests/Config/ConfigApiTests.cs` around lines 343 - 352, Add a
complementary unit test to exercise the conditional in the
LoggingRule.FinalMinLevel setter: create a test (e.g.,
LogRuleFinalMinLevel_DoesNotChangeExistingMinLevel) that constructs a
LoggingRule, sets rule.MinLevel = LogLevel.Debug (so _logLevelFilter is not
Off), then sets rule.FinalMinLevel = LogLevel.Warn and asserts that
rule.MinLevel remains LogLevel.Debug and rule.Levels contains the
debug-through-fatal levels; this verifies FinalMinLevel does not override an
existing MinLevel.