Skip to content

Version 6.0.5#6014

Merged
snakefoot merged 1 commit intoNLog:devfrom
snakefoot:ver605
Oct 9, 2025
Merged

Version 6.0.5#6014
snakefoot merged 1 commit intoNLog:devfrom
snakefoot:ver605

Conversation

@snakefoot
Copy link
Copy Markdown
Contributor

@snakefoot snakefoot commented Oct 4, 2025

@snakefoot snakefoot added this to the 6.0.5 milestone Oct 4, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 4, 2025

Walkthrough

Updated release metadata and changelog for Version 6.0.5; bumped build version prefix; refreshed PackageReleaseNotes; a small change to XML layout ToString formatting logic altering how ElementNameInternal and nested elements are rendered. No public API additions.

Changes

Cohort / File(s) Change Summary
Changelog
CHANGELOG.md
Added Version 6.0.5 (2025/10/09) entry under Improvements listing multiple items (FileTarget, ValueFormatter, ColoredConsoleTarget, NullTarget, XmlLoggingConfiguration, LoggerImpl, LoggingConfiguration, LoggingRule); preserved existing 6.0.4 section.
Build script
build.ps1
Bumped VersionPrefix from 6.0.4 to 6.0.5; derived version variables updated; build/publish logic unchanged.
Project metadata / Release notes
src/NLog/NLog.csproj
Replaced PackageReleaseNotes content with updated release-note items matching the changelog for 6.0.5.
XML layout formatting
src/NLog/Layouts/XML/XmlElementBase.cs
Modified ToString: when ElementNameInternal is present, nested elements are formatted as TagName={ElementNameInternal} instead of using l.ToString(); removed an explicit IncludeEventProperties=true representation path. Control flow adjusted for element rendering.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant XmlElement as XmlElementBase.ToString()
  participant Child as nested element(s)

  Caller->>XmlElement: ToString()
  alt ElementNameInternal is set
    XmlElement->>XmlElement: detect ElementNameInternal
    opt has nested elements
      XmlElement->>XmlElement: render as "TagName={ElementNameInternal}"
    end
  else ElementNameInternal not set
    alt has nested elements
      XmlElement->>Child: call l.ToString()
      Child-->>XmlElement: child string
      XmlElement->>XmlElement: combine child strings
    else
      XmlElement->>XmlElement: render attributes/context/default type name
    end
  end
  XmlElement-->>Caller: resulting string
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I twitch my whiskers — v6.0.5 arrives!
Notes scattered like clover under skies.
A script hop, a metadata sweep,
XML strings reshaped from deep.
Hooray — the burrow's neat, we celebrate with hops and jives. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly indicates the PR’s primary purpose of bumping the project to version 6.0.5, which directly reflects the core changes made across documentation and build files.
Description Check ✅ Passed The description provides a direct link to the updated changelog preview for version 6.0.5 and is clearly related to the documentation updates made in this PR.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@snakefoot snakefoot force-pushed the ver605 branch 2 times, most recently from d11073b to f852d1d Compare October 5, 2025 13:18
@snakefoot snakefoot force-pushed the ver605 branch 2 times, most recently from 0564fe1 to 032978b Compare October 5, 2025 13:53
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/NLog/Layouts/XML/XmlElementBase.cs (1)

800-812: Restore IncludeEventProperties branch in XmlElementBase.ToString

XmlElementBase.ToString() no longer shows IncludeEventProperties=true when set—JsonLayout’s ToString (src/NLog/Layouts/JSON/JsonLayout.cs:505–508) still does. Add an else if (IncludeEventProperties) branch (e.g., return $"{GetType().Name}: IncludeEventProperties=true";) to maintain diagnostic consistency.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f852d1d and 032978b.

📒 Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • build.ps1 (1 hunks)
  • src/NLog/Layouts/XML/XmlElementBase.cs (1 hunks)
  • src/NLog/NLog.csproj (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • build.ps1
🧰 Additional context used
🧬 Code graph analysis (1)
src/NLog/Layouts/XML/XmlElementBase.cs (2)
src/NLog/Layouts/Layout.cs (1)
  • ToStringWithNestedItems (504-512)
src/NLog/Layouts/JSON/JsonLayout.cs (1)
  • ToString (501-509)
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md

9-9: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🔇 Additional comments (2)
src/NLog/NLog.csproj (1)

30-52: LGTM! Release notes updated for version 6.0.5.

The PackageReleaseNotes section has been properly updated with the improvements included in this release. The changes are documentation-only and align with the version bump.

CHANGELOG.md (1)

7-23: LGTM! Changelog entry for version 6.0.5 is well-structured.

The new version entry follows the established format and includes all improvements with appropriate PR references. The date format and structure are consistent with previous entries.

@snakefoot snakefoot closed this Oct 5, 2025
@snakefoot snakefoot reopened this Oct 5, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@snakefoot snakefoot merged commit a023270 into NLog:dev Oct 9, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant