Conversation
… under copier/ folder
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
reviewed
Aug 23, 2024
lyashevska
requested changes
Aug 23, 2024
Collaborator
There was a problem hiding this comment.
thanks @fdiblen Great work! I have made a few comments/suggestions.
Co-authored-by: Olga Lyashevska <[email protected]>
Co-authored-by: Olga Lyashevska <[email protected]>
Co-authored-by: Olga Lyashevska <[email protected]>
Co-authored-by: Olga Lyashevska <[email protected]>
lyashevska
reviewed
Aug 23, 2024
Co-authored-by: Olga Lyashevska <[email protected]>
Co-authored-by: Olga Lyashevska <[email protected]>
lyashevska
approved these changes
Aug 23, 2024
Collaborator
lyashevska
left a comment
There was a problem hiding this comment.
Thanks again @fdiblen I like a lot that now we have a separate 'copier' folder with all the files. This simplifies things a lot. It looks good, we can merge this and polish things separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description:
copier.ymlinto multiple files and placed undercopier/folder. Here are the new yaml files:full_namefield indocs/conf.pyRelated issues:
Instructions to review the pull request
Generate packages with different feature combinations and check if you get the expected results.