Merged
Conversation
lyashevska
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
README.md
Outdated
| @@ -76,7 +85,7 @@ copier copy https://github.com/nlesc/python-template.git path/to/destination | |||
| Once the project files have been generated, follow the steps outlined in | |||
| [template/next_steps.md](template/next_steps.md). | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| [template/next_steps.md](template/next_steps.md). | |
| [next_steps.md](next_steps.md). |
Contributor
Author
There was a problem hiding this comment.
While the file will just be next_steps.md, if we functionally link to it, we have to link to template/next_steps.md.
I'll change just the text part, but leave the link intact.
fdiblen
reviewed
Aug 20, 2024
fdiblen
reviewed
Aug 20, 2024
fdiblen
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
fdiblen
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
lyashevska
reviewed
Aug 20, 2024
lyashevska
approved these changes
Aug 20, 2024
Collaborator
lyashevska
left a comment
lyashevska
left a comment
There was a problem hiding this comment.
thanks @sjvrijn Looks great, I have left a few suggestions.
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: Olga Lyashevska <[email protected]>
Co-authored-by: Olga Lyashevska <[email protected]>
Co-authored-by: Olga Lyashevska <[email protected]>
fdiblen
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #404, fixes #416
ADD_TO_EXISTING_PACKAGE.mdfileChecklist: