Skip to content

Set line-length to 79 characters according to PEP-8 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouweandela merged 9 commits into from
Sep 17, 2024
Merged

Set line-length to 79 characters according to PEP-8 #389

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
78f89e3
Set line-length to 79 characters according to PEP-8
bouweandela May 7, 2024
5b91cb4
Add changelog entry
bouweandela May 7, 2024
84e2f22
Fix line-length
bouweandela May 7, 2024
57016e4
Undo change to unused configuration
bouweandela May 16, 2024
99da4fb
Merge branch 'main' of github.com:NLeSC/python-template into line-length
bouweandela May 16, 2024
b980d4f
Merge branch 'main' of github.com:NLeSC/python-template into line-length
bouweandela Aug 27, 2024
3e89571
Merge branch 'main' of github.com:NLeSC/python-template into line-length
bouweandela Aug 28, 2024
6d41fb7
Merge branch 'main' of github.com:NLeSC/python-template into line-length
bouweandela Sep 2, 2024
f4413b8
Merge branch 'main' into line-length
bouweandela Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

### Changed

* Restored default line-length of 79 characters, as recommended by [PEP-8](https://peps.python.org/pep-0008/#maximum-line-length) [#389](https://github.com/NLeSC/python-template/pull/389)
* Moved from setup.cfg/.py to pyproject.toml [#351](https://github.com/NLeSC/python-template/issues/351)
* Moved from prospector to ruff [#336](https://github.com/NLeSC/python-template/issues/336)
* Renamed `project_name` to `directory_name` in cookiecutter questionnaire
Expand Down
17 changes: 9 additions & 8 deletions {{cookiecutter.directory_name}}/docs/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,12 @@

# -- Options for Intersphinx

intersphinx_mapping = {'python': ('https://docs.python.org/3', None),
# Commonly used libraries, uncomment when used in package
# 'numpy': ('http://docs.scipy.org/doc/numpy/', None),
# 'scipy': ('http://docs.scipy.org/doc/scipy/reference/', None),
# 'scikit-learn': ('https://scikit-learn.org/stable/', None),
# 'matplotlib': ('https://matplotlib.org/stable/', None),
# 'pandas': ('http://pandas.pydata.org/docs/', None),
}
intersphinx_mapping = {
'python': ('https://docs.python.org/3', None),
# Commonly used libraries, uncomment when used in package
# 'numpy': ('http://docs.scipy.org/doc/numpy/', None),
# 'scipy': ('http://docs.scipy.org/doc/scipy/reference/', None),
# 'scikit-learn': ('https://scikit-learn.org/stable/', None),
# 'matplotlib': ('https://matplotlib.org/stable/', None),
# 'pandas': ('http://pandas.pydata.org/docs/', None),
}
4 changes: 2 additions & 2 deletions {{cookiecutter.directory_name}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ force_single_line = 1
no_lines_before = ["FUTURE", "STDLIB", "THIRDPARTY", "FIRSTPARTY", "LOCALFOLDER"]
known_first_party = "{{ cookiecutter.package_name }}"
src_paths = ["{{ cookiecutter.package_name }}", "tests"]
line_length = 120
line_length = 79

# For completeness, until we move to an src-based layout
[tool.setuptools.packages.find]
Expand Down Expand Up @@ -166,7 +166,7 @@ per-file-ignores = {}
dummy-variable-rgx = "^(_+|(_+[a-zA-Z0-9_]*[a-zA-Z0-9]+?))$"

target-version = "py39"
line-length = 120
line-length = 79

[tool.ruff.isort]
known-first-party = ["{{ cookiecutter.package_name }}"]
Expand Down