Set line-length to 79 characters according to PEP-8#389
Merged
bouweandela merged 9 commits intomainfrom Sep 17, 2024
Merged
Conversation
egpbos
reviewed
May 15, 2024
Collaborator
egpbos
left a comment
egpbos
left a comment
There was a problem hiding this comment.
Minor question, LGTM otherwise.
Member
|
Hey @bouweandela , The template is using copier now. Will you have time to update this PR? |
bouweandela
commented
Aug 27, 2024
Member
Author
Collaborator
|
Hi @bouweandela, what is the status of this PR? I see that #591 was merged, should this be reviewed/merged next? I see that the branch is currently out-of-date with |
Member
Author
Yes |
vedran-kasalica
approved these changes
Sep 17, 2024
Collaborator
vedran-kasalica
left a comment
vedran-kasalica
left a comment
There was a problem hiding this comment.
@bouweandela the changes look good to me and the PR can be merged!
Thinking about the limit itself, the user can always change the default if they want to have it longer, it's good to follow the guidelines we endorse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Limit line length to 79 characters, as prescribed by PEP-8.
Closes #388