Merged
Conversation
7616a0f to
d5e299d
Compare
Collaborator
Author
|
Ready for review @sverhoeven, @bvreede |
Everywhere: on CI, in tests, in docs. Also, we replace bare pip/pip3 and pytest calls with python -m pip and python -m pytest respectively, to make sure we always use the same python executable everywhere. This fixes #326 (failing Windows tests on CI), because the `python3` executable causes issues (it is not properly copied into the venv directory by venv, which is a CPython bug, see python/cpython#87915), while the python executable does work; see e.g. here https://stackoverflow.com/questions/61669873/python-venv-env-fails-winerror-2-the-system-cannot-find-the-file-specified. `python` should be the same executable under the hood as `python3`, if the setup-python action works as expected, at least. It also allows us to remove the IS_WINDOWS_CI special case. Failed attempts at fixing #326 included: - Setting the shells (assuming something went wrong with environment variables) - Using full paths for both the executable and the venv directory in the template test suite.
d5e299d to
9686cf7
Compare
Collaborator
Author
|
(one more force push, I accidentally rebased a previous commit) |
bvreede
approved these changes
Jul 10, 2023
Contributor
bvreede
left a comment
There was a problem hiding this comment.
It works!
Very happy for this to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #326, don't merge, I'm just using this PR to run CI, because I don't have Windows locally.