Merged
Conversation
abelsiqueira
approved these changes
Oct 18, 2021
Member
abelsiqueira
left a comment
abelsiqueira
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
on: [push, pull_request], GitHub Actions will trigger CI jobs twice (when you are branching in the repo itself): once for pushing to the PR branch and once for the PR itself. This is wasteful of resources and also makes the overview unnecessarily cluttered. This PR triggers only on direct pushes to main and on PRs to main. This means that it won't trigger anymore on pushes to other branches, but this can easily be "reactivated" by creating a (draft) PR from your other branch.