Skip to content

fix: ensure that captured errors during business rule evaluation are being captured and logged #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeRobertson merged 1 commit into from
Feb 18, 2026
Merged

fix: ensure that captured errors during business rule evaluation are being captured and logged #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions src/dve/core_engine/backends/base/rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def _step_metadata_to_location(step_metadata: "AbstractStep") -> str:

def _handle_rule_error(self, error: Exception, config: AbstractStep) -> Messages:
"""Log an error and create appropriate error messages."""
return render_error(error, self._step_metadata_to_location(config))
return render_error(error, self._step_metadata_to_location(config), self.logger)

def evaluate(self, entities, *, config: AbstractStep) -> tuple[Messages, StageSuccessful]:
"""Evaluate a step definition, applying it to the entities."""
Expand Down Expand Up @@ -411,7 +411,7 @@ def apply_sync_filters(
CriticalProcessingError(
"Issue occurred while applying filter logic",
messages=[
msg.error_message
msg.error_message # type: ignore
for msg in temp_messages
if msg.error_message
],
Expand Down Expand Up @@ -439,7 +439,10 @@ def apply_sync_filters(
[
CriticalProcessingError(
"Issue occurred while generating FeedbackMessages",
[msg.error_message for msg in temp_messages],
messages=[
msg.error_message # type: ignore
for msg in temp_messages
],
)
],
)
Expand Down Expand Up @@ -467,7 +470,10 @@ def apply_sync_filters(
[
CriticalProcessingError(
"Issue occurred while generating FeedbackMessages",
[msg.error_message for msg in temp_messages],
messages=[
msg.error_message # type: ignore
for msg in temp_messages
],
)
],
)
Expand Down Expand Up @@ -505,7 +511,9 @@ def apply_sync_filters(
[
CriticalProcessingError(
"Issue occurred while filtering error records",
[msg.error_message for msg in temp_messages],
messages=[
msg.error_message for msg in temp_messages # type: ignore
],
)
],
)
Expand Down Expand Up @@ -533,7 +541,10 @@ def apply_sync_filters(
[
CriticalProcessingError(
"Issue occurred while generating FeedbackMessages",
[msg.error_message for msg in temp_messages],
messages=[
msg.error_message # type: ignore
for msg in temp_messages
],
)
],
)
Expand Down Expand Up @@ -592,7 +603,9 @@ def apply_rules(
[
CriticalProcessingError(
"Issue occurred while applying pre filter steps",
[msg.error_message for msg in stage_messages],
messages=[
msg.error_message for msg in stage_messages # type: ignore
],
)
],
)
Expand Down Expand Up @@ -644,7 +657,9 @@ def apply_rules(
[
CriticalProcessingError(
"Issue occurred while applying post filter steps",
[msg.error_message for msg in stage_messages],
messages=[
msg.error_message for msg in stage_messages # type: ignore
],
)
],
)
Expand Down