Revert "Core: Use encoding/decoding methods for namespaces and deprecate Splitter/Joiner"#11574
Merged
Merged
Conversation
…ate Spli…" This reverts commit 5fc1413.
Contributor
|
I'm not convinced we need to revert this. In my test env I have Trino 465 + 1.7 with nested namespaces enabled, connecting to an Iceberg 1.6 REST catalog. I'm seeing the same error in the REST catalog: |
Contributor
Author
|
@bryanck the issue is that the 1.7 client sends the query param (where the nested namespace is encoded) using |
bryanck
approved these changes
Nov 19, 2024
3 tasks
Contributor
|
I retested this and this does resolve the issue (I tested the wrong Trino build previously). |
Contributor
Author
|
thanks for reviewing and testing this @bryanck |
This was referenced Nov 19, 2024
Merged
11 tasks
|
Related issue #11539 |
This was referenced Nov 20, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
…ate Spli…" (apache#11574) This reverts commit 5fc1413.
nastra
added a commit
to nastra/iceberg
that referenced
this pull request
Oct 7, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra
added a commit
to nastra/iceberg
that referenced
this pull request
Oct 7, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra
added a commit
to nastra/iceberg
that referenced
this pull request
Oct 8, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra
added a commit
to nastra/iceberg
that referenced
this pull request
Oct 8, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
nastra
added a commit
to nastra/iceberg
that referenced
this pull request
Oct 8, 2025
This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
danielcweeks
pushed a commit
that referenced
this pull request
Oct 8, 2025
…14274) This revisits #10858 (which was reverted in #11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
thomaschow
pushed a commit
to thomaschow/iceberg
that referenced
this pull request
Jan 19, 2026
…pache#14274) This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
talatuyarer
pushed a commit
to talatuyarer/iceberg
that referenced
this pull request
Apr 1, 2026
…pache#14274) This revisits apache#10858 (which was reverted in apache#11574) and uses separate method to join/split a namespace using the unicode character \001f. We eventually want to make the namespace separator configurable and in order to do that, all namespace joining/splitting needs to go through respective methods instead of using the Joiner/Splitter directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10858
I'll revert this one for now and do a proper fix for 1.8.0