fix(gh,github,junit): attach test:log to the test that emitted it - #275

test:log is execution-ordered: Node forwards it the moment t.log() runs, bypassing the per-file declaration-order buffer that test:diagnostic waits in (kExecutionOrderedEvents). gh, github and junit structure their output by test, so rendering a log on arrival files it under whichever test happens to be printing.

Two concurrent files, @reporters/gh under Actions — before:

A1 log before
B1 log                     <- file B's log, before A reports at all
A1 log after
::group::✔ A one
A1 diagnostic              <- correct, Node ordered it
A2 log                     <- A two's log, inside A one's group
::endgroup::
::group::✔ A two
B2 log late                <- B two's log, inside A two's group
::endgroup::

after:

::group::✔ A one
A1 log before
A1 log after
A1 diagnostic
::endgroup::
::group::✔ A two
A2 log
::endgroup::

@reporters/junit had it worse — the misplacement is in the document, not just the display:

<!-- A1 log before -->
<!-- B1 log -->
<testcase name="A one" .../>
<!-- A2 log -->
<testcase name="A two" .../>

What changed

Each log is held keyed by (entryFile ?? file, testId) and emitted when its owner reports — the position test:diagnostic already occupies.

• @reporters/github — new log_buffer.js, exported as @reporters/github/log_buffer. Annotations flush at test:pass/test:fail, including the subtestsFailed path that emits no annotation of its own.
• @reporters/gh — its own buffer instance; flushed lines land after the group header. Buffers in and out of GitHub Actions so local output matches CI.
• @reporters/junit — its own copy of the map, so the package stays dependency-free. Logs attach after the testcase/testsuite decision, so a logged test can't become a suite.

Logs whose test never reports — an interrupted run, or a t.log() that outlived its test — are emitted at the end rather than dropped.

Two bugs fixed in the same code path: a log with no location crashed @reporters/github in extractLocation (Cannot read properties of undefined (reading 'startsWith')), and the log's data payload was dropped from the annotation (gh rendered it, github didn't).

Not changed

live, web and testwatch stream their output — real-time logging is what test:log exists for, and they're the reporters built for it.

junit logs stay XML comments. <system-out> would be more useful to CI parsers, but it's a format change, and comments are deliberately excluded from the nonCommentChildren count that decides testcase vs testsuite.

Known limitation

Under process isolation, (file, testId) collides across processes when tests are declared in a shared helper file — the same defect already tracked for the tree store. Reading entryFile first makes this correct automatically once nodejs/node#64309 lands.

Upstream

Node's built-in junit and tap reporters have the identical defect; a fix is in progress separately. spec is left live by design.

Verification

436 tests pass, 100% statements/lines, branch coverage 95.38% → 95.79%, lint clean. New regression tests in all three packages cover: a log flushing inside its owner's group, a sibling's log not leaking into a foreign group, cross-file interleaving, multiple logs keeping their order, an orphan drained at end of run, gh rendering a log exactly once (it wraps upstream spec, which would double-print if the event were forwarded), and github tolerating a location-less log.

Also verified end-to-end against real Node v26.6.0 runs — nested, concurrent, in and out of Actions — and the suite re-run with GITHUB_ACTIONS=1 to exercise the CI paths.

🤖 Generated with Claude Code