Merged
Conversation
e540b5a to
8685d93
Compare
McOso
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added following Integration tests
-> RedemptionBatchSizeLimitsTest.t.sol - tests different batch sizes of delegations
-> DelegationChainMaxDepthTest.t.sol - tests delegation chain of varying depth
-> DelegationChainWithCaveatsTest.t.sol - end to end test with different caveats
-> New test to ERC20StreamingEnforcer - depleting allowance in EXECTYPE_TRY mode (this is now fixed)
-> ERC20TransferAmountEnforcer - depleting allowance in EXECTYPE_TRY mode (this is now fixed)
-> MixedAuthorityDelegationTest.t.sol - delegation chain with different delegation types (hybrid / MultiSig / 7702)
-> RevokeDelegationMidChainTest.t.sol - tests revocation of delegation mid chain
Why?