Skip to content

chore(composable-controller): replace Sinon with Jest mocks#7964

Merged
cryptodev-2s merged 1 commit intomainfrom
chore/composable-controller-replace-sinon-with-jest
Feb 18, 2026
Merged

chore(composable-controller): replace Sinon with Jest mocks#7964
cryptodev-2s merged 1 commit intomainfrom
chore/composable-controller-replace-sinon-with-jest

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 17, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only refactor and devDependency cleanup; production code paths are unchanged.

Overview
Removes the sinon devDependency from @metamask/composable-controller (and the corresponding yarn.lock entry).

Updates ComposableController.test.ts to replace sinon.stub() usage with jest.fn() and switches assertions to Jest call tracking, eliminating the sinon.restore() cleanup hook.

Written by Cursor Bugbot for commit 4496003. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s self-assigned this Feb 17, 2026
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner February 17, 2026 21:20
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 1093edf Feb 18, 2026
308 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/composable-controller-replace-sinon-with-jest branch February 18, 2026 13:04
khanti42 pushed a commit that referenced this pull request Feb 20, 2026
## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Test-only refactor and devDependency cleanup; production code paths
are unchanged.
> 
> **Overview**
> Removes the `sinon` devDependency from
`@metamask/composable-controller` (and the corresponding `yarn.lock`
entry).
> 
> Updates `ComposableController.test.ts` to replace `sinon.stub()` usage
with `jest.fn()` and switches assertions to Jest call tracking,
eliminating the `sinon.restore()` cleanup hook.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
4496003. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants