inspector: migrate node to js_protocol.pdl

alexkozy · MayaLekova · commit a79eed3f69a1 · 2018-05-08T17:35:37.000+02:00
On inspector side we are going to deprecate .json protocol definition formation and replace it with new .pdl format. New format allows us to use multiline commends and contains less noise in comparision then .json. PR-URL: nodejs#20141 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@keybase.io>
diff --git a/node.gyp b/node.gyp
@@ -672,11 +672,32 @@
       'conditions': [
         [ 'v8_enable_inspector==1', {
           'actions': [
+            {
+              'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder',
+              'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ],
+              'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ],
+              'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ],
+            },
+            {
+              'action_name': 'v8_inspector_convert_protocol_to_json',
+              'inputs': [
+                '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl',
+              ],
+              'outputs': [
+                '<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
+              ],
+              'action': [
+                'python',
+                'deps/v8/third_party/inspector_protocol/ConvertProtocolToJSON.py',
+                '<@(_inputs)',
+                '<@(_outputs)',
+              ],
+            },
             {
               'action_name': 'v8_inspector_compress_protocol_json',
               'process_outputs_as_sources': 1,
               'inputs': [
-                'deps/v8/src/inspector/js_protocol.json',
+                '<(SHARED_INTERMEDIATE_DIR)/js_protocol.json',
               ],
               'outputs': [
                 '<(SHARED_INTERMEDIATE_DIR)/v8_inspector_protocol_json.h',
