sql-parser: absorb separate sql parser repository#1384
Merged
benesch merged 2 commits intoMaterializeInc:masterfrom Dec 24, 2019
Merged
sql-parser: absorb separate sql parser repository#1384benesch merged 2 commits intoMaterializeInc:masterfrom
benesch merged 2 commits intoMaterializeInc:masterfrom
Conversation
benesch
force-pushed
the
absorb-sqlparser
branch
2 times, most recently
from
213d393 to
1942eac
Compare
benesch
force-pushed
the
absorb-sqlparser
branch
3 times, most recently
from
4b2d62f to
ca37d82
Compare
Absorb MaterializeInc/sqlparser as a new crate named sql-parser. Having a separate repository actively hinders Materialize development, as every change requires at least three steps: making the change int he sqlparser repository, bumping the version of sqlparser in the materialize repository, and then actually using the new feature in the materialize repository. For a while, the upstream library was seeing active development, so a separate repository made sense, as it eased the process of incorporating upstream patches. But at this point we've far surpassed upstream in our SQL parsing capabilities, and development upstream has stalled entirely. Plus, upstream has the dubious goal of supporting all popular SQL dialects, while we have the simpler task of just supporting the Materialize SQL dialect; ripping out support for the other dialects will make the code much simpler. This is a direct import of the sqlparser repository, modulo changes to the license header and Cargo.toml. Cleanups will follow in future commits.
We don't use this feature, so it's not worth the extra complexity.
benesch
force-pushed
the
absorb-sqlparser
branch
from
ca37d82 to
63d2c24
Compare
Contributor
Author
|
As discussed in Slack, this is now still licensed under Apache 2. Merging because this is blocking a bunch of other work (see MaterializeInc/database-issues#492) and the import was very mechanical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absorb MaterializeInc/sqlparser as a new crate named sql-parser.
Having a separate repository actively hinders Materialize development,
as every change requires at least three steps: making the change in the
sqlparser repository, bumping the version of sqlparser in the
materialize repository, and then actually using the new feature in the
materialize repository.
For a while, the upstream library was seeing active development, so a
separate repository made sense, as it eased the process of incorporating
upstream patches. But at this point we've far surpassed upstream in our
SQL parsing capabilities, and development upstream has stalled entirely.
Plus, upstream has the dubious goal of supporting all popular SQL
dialects, while we have the simpler task of just supporting the
Materialize SQL dialect; ripping out support for the other dialects will
make the code much simpler.
This is a direct import of the sqlparser repository, modulo changes to
the license header and Cargo.toml. Cleanups will follow in future
commits.