Skip to content

feat: register lerian-hq in deployment matrix (benedita)#368

Merged
prymax10 merged 2 commits into
developfrom
feat/deployment-matrix-lerian-hq
May 14, 2026
Merged

feat: register lerian-hq in deployment matrix (benedita)#368
prymax10 merged 2 commits into
developfrom
feat/deployment-matrix-lerian-hq

Conversation

@prymax10
Copy link
Copy Markdown
Contributor

@prymax10 prymax10 commented May 14, 2026 •
edited by coderabbitai Bot
Loading

What

Registers lerian-hq (Lerian internal hub, https://github.com/LerianStudio/lerian-hq) as a deployable app for the benedita cluster.

 apps:
   registry:
     ...
     # Clotilde-exclusive Lerian platform suite
     - backoffice-console
     - cs-platform
     - forge
+    - lerian-hq
     - lerian-map
     - tenant-manager

 clusters:
   benedita:
     apps:
       ...
       - forge
+      - lerian-hq
       - lerian-map
       - tenant-manager

Why

Without this, the gitops-update.yml reusable workflow has no way to resolve which cluster(s) lerian-hq deploys to, so tag-bump pushes from the app repo's build.yml would silently no-op against the gitops repo. After this PR merges, the app repo's update_gitops job (separate PR on LerianStudio/lerian-hq) will be able to bump .lerian-hq.image.tag in environments/benedita/helmfile/applications/dev/lerian-hq/values.yaml on every image release.

Scope

  • Added to benedita cluster only. Not deployed to clotilde / anacleto / firmino.
  • The 'Clotilde-exclusive' comment in apps.registry is technically outdated already (lerian-map and friends also run on benedita) — left as-is to avoid bundling a comment-cleanup with this functional change.

Verification

  • YAML parses
  • Alphabetical position consistent with surrounding entries
  • No unintended deltas (diff is purely +2 lines)

Summary by CodeRabbit

  • Chores
    • Enabled lerian-hq in the global apps registry allow-list.
    • Registered lerian-hq for deployment to the benedita cluster.
    • This registration makes the automated deployment workflow eligible to resolve and target lerian-hq for benedita.

Review Change Stack

@prymax10 prymax10 requested a review from a team as a code owner May 14, 2026 17:14
@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 14, 2026 •
edited
Loading

⚠️ Invalid Source Branch

Pull requests to main can only come from:

  • develop
  • hotfix/*

Your source branch: feat/deployment-matrix-lerian-hq

Please change the base branch or create a PR from an allowed branch.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: cfe39123-ebd5-46ae-b221-338370bce792

📥 Commits

Reviewing files that changed from the base of the PR and between dae03e8 and d269514.

📒 Files selected for processing (1)
  • config/deployment-matrix.yml

Walkthrough

Adds lerian-hq to the deployment matrix: registers it in the global apps.registry allow-list and lists it under clusters.benedita.apps, enabling the GitOps workflow to resolve and deploy it to the benedita cluster.

Changes

Deployment Matrix Configuration

Layer / File(s) Summary
Register lerian-hq for benedita cluster deployment
config/deployment-matrix.yml		 lerian-hq is added to the global apps.registry allow-list (Lerian internal platform suite) and to clusters.benedita.apps, allowing gitops-update.yml to resolve and deploy it to the benedita cluster.

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs:

Suggested labels:
deployment-matrix, size/XS, validate

Suggested reviewers:

  • bedatty
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive Description covers what, why, scope, and verification, but does not follow the required template structure with Type of Change checkboxes and Testing section. Use the repository template format with Type of Change selection and Testing validation section to ensure consistency with contribution guidelines.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately describes the main change: registering lerian-hq in the deployment matrix for the benedita cluster.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/deployment-matrix-lerian-hq

Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 14, 2026 •
edited
Loading

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio
Copy link
Copy Markdown
Contributor

lerian-studio commented May 14, 2026 •
edited
Loading

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 1 file(s) ✅ success
Action Lint no changes ⏭️ skipped
Pinned Actions no changes ⏭️ skipped
Markdown Link Check no changes ⏭️ skipped
Spelling Check 1 file(s) ✅ success
Shell Check no changes ⏭️ skipped
README Check no changes ⏭️ skipped
Composite Schema no changes ⏭️ skipped
Deployment Matrix 1 file(s) ✅ success

🔍 View full scan logs

coderabbitai[bot]
coderabbitai Bot reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
config/deployment-matrix.yml (1)

54-58: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Update stale exclusivity header near the new registry entry.

Line 54 says “Clotilde-exclusive,” but lerian-hq is now also in benedita (Line 136). Rename this header to avoid misleading future matrix updates.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config/deployment-matrix.yml` around lines 54 - 58, The header
"Clotilde-exclusive Lerian platform suite" is misleading because the service
lerian-hq is also listed under benedita; rename that header to a neutral title
(for example "Lerian platform suite") in the block containing
backoffice-console, cs-platform, forge, and lerian-hq so it no longer implies
Clotilde exclusivity.
🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@config/deployment-matrix.yml`:
- Around line 54-58: The header "Clotilde-exclusive Lerian platform suite" is
misleading because the service lerian-hq is also listed under benedita; rename
that header to a neutral title (for example "Lerian platform suite") in the
block containing backoffice-console, cs-platform, forge, and lerian-hq so it no
longer implies Clotilde exclusivity.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c5b85af5-af72-4518-bec0-3ccbc84d7c2e

📥 Commits

Reviewing files that changed from the base of the PR and between 780fb5d and 6acb639.

📒 Files selected for processing (1)
  • config/deployment-matrix.yml

Primo Soares added 2 commits May 14, 2026 17:05
@prymax10
feat: register lerian-hq in deployment matrix (benedita)
4c64ef9 
Adds lerian-hq to apps.registry and clusters.benedita.apps so the
gitops-update reusable workflow can resolve benedita as a deployment
target for the lerian-hq app.

Scope: benedita only — lerian-hq is an internal hub deployed via the
midaz-firmino-gitops overlay at environments/benedita/.../lerian-hq.
Not deployed to clotilde / anacleto / firmino.
@prymax10
chore: relabel platform-suite section (Clotilde + Benedita)
d269514 
The 'Clotilde-exclusive' comment was outdated already (lerian-map,
forge, backoffice-console, cs-platform, tenant-manager all run on
benedita too). Renaming this section in the same change that introduces
lerian-hq under it.
@prymax10 prymax10 force-pushed the feat/deployment-matrix-lerian-hq branch from dae03e8 to d269514 Compare May 14, 2026 20:05
@prymax10 prymax10 changed the base branch from main to develop May 14, 2026 20:05
@lerian-studio lerian-studio added size/XS PR changes < 50 lines deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) labels May 14, 2026
@prymax10 prymax10 merged commit 16b0e68 into develop May 14, 2026
68 of 69 checks passed
@prymax10 prymax10 deleted the feat/deployment-matrix-lerian-hq branch May 14, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@prymax10 prymax10

Labels

deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) size/XS PR changes < 50 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prymax10 @lerian-studio