fix: increase golangci-lint timeout from 5m to 10m - #70
Merged
Merged
Conversation
Repos with large dependency trees (e.g., mcp with 143 deps) need ~6m for golangci-lint to compile and analyze on CI runners. The 5m timeout causes false failures. Bumping to 10m gives headroom without affecting repos that finish faster. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
dunganle
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Repos with large dependency trees (e.g.,
Kochava/mcpwith 143 deps) need ~6 minutes for golangci-lint to compile and analyze on CI runners. The current--timeout=5mcauses the linter to exit with code 4 (timeout) even when there are 0 lint issues:Fix
Bump
--timeout=5mto--timeout=10m. This is a safe change — repos that finish quickly are unaffected (the timeout is just a ceiling, not a delay). Only repos with large dependency trees benefit.Context
This is the final piece after #68 (
only-new-issues,fetch-depth: 0) and #69 (revert version pin). Those changes are working correctly — the linter now reports only new issues and uses a Go-compatible version. This just gives it enough time to finish the analysis.After merge,
go/app/v1tag needs to be moved to the new main HEAD.🤖 Generated with Claude Code