Refactor: Upgrade to Python 3 and add unit tests.#2
Open
Conversation
I've upgraded Crawler.py and Indexer.py from Python 2 to Python 3.
This involved:
- Updating syntax (print to print(), Tkinter to tkinter, etc.).
- Replacing urllib2 with urllib.
- Using modern practices like set() and urljoin.
I've also added unit tests for:
- Crawler.py:
- get_anchor_tag()
- get_proper_link()
- Indexer.py:
- parse_document()
- create_small_table()
- add_to_big_table()
I fixed bugs in Crawler.py related to URL joining and HTML parsing during the upgrade.
I also improved Indexer.py's parse_document to normalize to lowercase.
All new unit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've upgraded Crawler.py and Indexer.py from Python 2 to Python 3. This involved:
I've also added unit tests for:
I fixed bugs in Crawler.py related to URL joining and HTML parsing during the upgrade. I also improved Indexer.py's parse_document to normalize to lowercase. All new unit tests pass.