Open
Conversation
Member
|
Would it be possible to print fewer hdots? Matrices and data frames print only one every 5-6 rows. |
tighter test bounds
Contributor
Author
|
@nalimilan ready for another review round. |
nalimilan
reviewed
Oct 8, 2022
Comment on lines
+85
to
+89
| ct = CoefTable(rand(15,100), ["c$i" for i in 1:100], [], 4) | ||
| sct = sprint(show, ct, context=:limit=>false) | ||
| @test textwidth(first(split(sct, '\n'))) > 900 | ||
| sct = sprint(show, ct, context=:limit=>true) | ||
| @test textwidth(first(split(sct, '\n'))) <= displaysize()[2] |
Member
There was a problem hiding this comment.
Haven't you found a way to test the exact output as discussed above?
Contributor
Author
There was a problem hiding this comment.
The displaysize() returns current terminal dimensions, what ever they may be in the CI environment. I would assume standard 80x25.
Member
There was a problem hiding this comment.
Yes I think it's same to assume that, and check the string output for these dimensions.
Co-authored-by: Milan Bouchet-Valat <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large tables tend to mess output by wrapping lines. See JuliaStats/MultivariateStats.jl#186.
This PR make
CoefTablewidth adjustable by omitting columns that are not fit into the screen.