Skip files in .gitignore.#840
Merged
JohnnyMorganz merged 1 commit intoJohnnyMorganz:mainfrom Dec 30, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 16 16
Lines 5995 5995
=======================================
Hits 5817 5817
Misses 178 178 ☔ View full report in Codecov by Sentry. |
JohnnyMorganz
approved these changes
Dec 27, 2023
Owner
JohnnyMorganz
left a comment
JohnnyMorganz
left a comment
There was a problem hiding this comment.
Thanks!
Could you also update the changelog?
This is a common behavior of formatters (e.g Ruff and Black) as it's arguably a more useful default behavior. Closes JohnnyMorganz#833.
dundargoc
force-pushed
the
feat/gitignore
branch
from
11ae181 to
88335f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a common behavior of formatters (e.g Ruff and Black) as it's arguably a more useful default behavior.
Closes #833.