Skip to content

Commit 91045da

Browse files
author
Mark Hahnenberg
committed
Worker tear-down can re-enter JSC during GC finalization
https://bugs.webkit.org/show_bug.cgi?id=88449 Reviewed by Geoffrey Garen. No new tests. This is the first of two patches to fix this issue with Workers. * workers/AbstractWorker.cpp: (WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it will be called elsewhere in contextDestroyed(). Canonical link: https://commits.webkit.org/106379@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent a700e3d commit 91045da

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

‎Source/WebCore/ChangeLog‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2012-06-07 Mark Hahnenberg <[email protected]>
2+
3+
Worker tear-down can re-enter JSC during GC finalization
4+
https://bugs.webkit.org/show_bug.cgi?id=88449
5+
6+
Reviewed by Geoffrey Garen.
7+
8+
No new tests.
9+
10+
This is the first of two patches to fix this issue with Workers.
11+
12+
* workers/AbstractWorker.cpp:
13+
(WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
14+
will be called elsewhere in contextDestroyed().
15+
116
2012-06-07 Jer Noble <[email protected]>
217

318
sometimes all slaved videos don't start playing

‎Source/WebCore/workers/AbstractWorker.cpp‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ AbstractWorker::AbstractWorker(ScriptExecutionContext* context)
5353

5454
AbstractWorker::~AbstractWorker()
5555
{
56-
onDestroyWorker();
5756
}
5857

5958
void AbstractWorker::onDestroyWorker()

0 commit comments

Comments
 (0)