Skip to content

Commit 12eef4a

Browse files
philnphiln
committed
[WPE][Qt] TestRunJavaScript failure
https://bugs.webkit.org/show_bug.cgi?id=205766 Reviewed by Carlos Garcia Campos. * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: (TestRunJavaScript::main): Surround JS function with parentheses to comply with the ECMAScript specification. Canonical link: https://commits.webkit.org/218924@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 0d0456a commit 12eef4a

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

‎Tools/ChangeLog‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
2020-01-06 Philippe Normand <[email protected]>
2+
3+
[WPE][Qt] TestRunJavaScript failure
4+
https://bugs.webkit.org/show_bug.cgi?id=205766
5+
6+
Reviewed by Carlos Garcia Campos.
7+
8+
* TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
9+
(TestRunJavaScript::main): Surround JS function with parentheses
10+
to comply with the ECMAScript specification.
11+
112
2020-01-05 Sam Weinig <[email protected]>
213

314
Further simplify StringBuilder usage by standardizing hex formating to a single hex() function

‎Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ void TestRunJavaScript::main()
3737
QVERIFY(!m_view->isLoading());
3838
QCOMPARE(m_view->title(), title);
3939
const QString tstProperty = QString(QLatin1String("Qt.tst_data"));
40-
QJSValue callback = m_engine.evaluate(QString("function(result) { %1 = result; }").arg(tstProperty));
40+
QJSValue callback = m_engine.evaluate(QString("(function(result) { %1 = result; })").arg(tstProperty));
4141
QVERIFY2(!callback.isError(), qPrintable(callback.toString()));
4242
QVERIFY(!callback.isUndefined());
4343
QVERIFY(callback.isCallable());

0 commit comments

Comments
 (0)