🐛 Fix support for functools wraps and partial combined, for async and regular functions and classes in path operations and dependencies #14448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eration functions
…t, as that's the special case
Member
Author
|
This is now released in FastAPI 0.123.6 🎉 |
1 task
|
Thanks @tiangolo for the quick fix and release. |
|
Thanks a LOT! That was super quick :)! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix support for functools wraps and partial combined, for async and regular functions and classes in path operations and dependencies
This also uses and extends the tests created by @YuriiMotov 🙌
Should fix / related to: #14444
The new tests simulate the multiple combinations of how decorators could affect dependencies and path operation functions (endpoints).
The logic to analyze if a function is an async, generator, async generator, callable instance, etc. now also checks and unwraps and extracts partials in all those levels.
The main case is when the callable is an async something (function, generator, etc) because then it needs to be awaited.
But the original function could be async or not, the wrapper could be async or not. if either is async, then it has to be awaited, no matter if the other is not async. So, analyzing only the last point in the chain is not enough, it's necessary to analyze the function but also the wrapper.
This PR implements and tests all that, all those combinations.