Skip to content

feat: Allow OUTER keyword as function parameter name #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manticore-projects merged 2 commits into from
Jun 14, 2024
Merged

feat: Allow OUTER keyword as function parameter name #2021

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72fab91
feat: Allow OUTER keyword as function parameter name
mountaincrab Jun 14, 2024
c58f128
chore: Spotless
mountaincrab Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: Allow OUTER keyword as function parameter name
  • Loading branch information
@mountaincrab
mountaincrab committed Jun 14, 2024
commit 72fab911301cd28a1fe25570432afa471291f884
7 changes: 4 additions & 3 deletions src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4619,15 +4619,16 @@ JdbcNamedParameter JdbcNamedParameter() : {
}

OracleNamedFunctionParameter OracleNamedFunctionParameter() : {
String name;
Token token = null;
String name = null;
Expression expression;
}
{
name=RelObjectNameExt2()
( name=RelObjectNameExt2() | token=<K_OUTER> )
<K_ORACLE_NAMED_PARAMETER_ASSIGNMENT>
expression=Expression()
{
return new OracleNamedFunctionParameter(name, expression);
return new OracleNamedFunctionParameter(name != null ? name : token.image, expression);
}
}

Expand Down
16 changes: 16 additions & 0 deletions src/test/java/net/sf/jsqlparser/statement/select/TableFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,20 @@ void testLateralFlat() throws JSQLParserException {
TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
}

/**
* The SQL keyword "OUTER" is a valid parameter name for Snowflake's FLATTEN table function.
*/
@Test
void testTableFunctionWithNamedParameterWhereNameIsOuterKeyword() throws JSQLParserException {
String sqlStr =
"INSERT INTO db.schema.target\n" +
" (Name, FriendParent)\n" +
" SELECT\n" +
" i.DATA_VALUE:Name AS Name,\n" +
" f1.Value:Parent:Name AS FriendParent\n" +
" FROM\n" +
" db.schema.source AS i,\n" +
" lateral flatten(input => i.DATA_VALUE:Friends, outer => true) AS f1;";
TestUtils.assertSqlCanBeParsedAndDeparsed(sqlStr, true);
}
}