Okay, I've made a test.performance.js file with my case (based on @codan84 answer), however, note that I am running it on a very slow CPU that may be 5x slower than yours, so you may need to increase these numbers to make it fail, here's the gist:
https://gist.github.com/zb3/d6ea67cc7403c2e51caf0fca8bf18337

However, I don't really understand why this clone is needed, since the ret reference is not passed anywhere, so no other part of code can make use of that. Also, if you want to simply return it in case isParentSelector isn't present (which means we won't clone it in that case), why not support all cases? Correct me if I'm wrong.

Anyway, for anyone interested, here's the code I am currently using, that acts like the old one:

    // We check the resulting values for parent selections. For parent
    // selections we discard the value object and continue the trace with the
    // current val object
    for (var t = 0, tt; t < ret.length; t++) {
        if (ret[t].isParentSelector) {
            var tmp = self._trace(ret[t].expr, val, ret[t].path, parent, parentPropName, callback);
            if (Array.isArray(tmp)) {
                ret[t] = tmp[0];

                for (tt = 1; tt < tmp.length; tt++) {
                    t++;
                    ret.splice(t, 0, tmp[tt]);
                }
            } else {
                ret[t] = tmp;
            }
        }
    }

And also a simpler version for the addRet part:

    function addRet (elems) {
        if (Array.isArray(elems)) {
            for (var t = 0; t < elems.length; t++) {
                ret.push(elems[t]);
            }
        } else {
            ret.push(elems);
        }
    }

Uh oh!

terribly slow #14

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions